Skip to content

Commit 05a4579

Browse files
committed
Address Code Review
1 parent 7af45ef commit 05a4579

5 files changed

Lines changed: 539 additions & 778 deletions

File tree

src/core/src/bootstrap/ConfigurationFactory.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,19 @@ def __init__(self, log_file_path, events_folder, telemetry_supported):
7171

7272
self.configurations = {
7373
'apt_prod_config': self.new_prod_configuration(Constants.APT, AptitudePackageManager),
74-
'dnf5_prod_config': self.new_prod_configuration(Constants.DNF, Dnf5PackageManager),
74+
'dnf5_prod_config': self.new_prod_configuration(Constants.DNF5, Dnf5PackageManager),
7575
'tdnf_prod_config': self.new_prod_configuration(Constants.TDNF, AzL3TdnfPackageManager),
7676
'yum_prod_config': self.new_prod_configuration(Constants.YUM, YumPackageManager),
7777
'zypper_prod_config': self.new_prod_configuration(Constants.ZYPPER, ZypperPackageManager),
7878

7979
'apt_dev_config': self.new_dev_configuration(Constants.APT, AptitudePackageManager),
80-
'dnf5_dev_config': self.new_dev_configuration(Constants.DNF, Dnf5PackageManager),
80+
'dnf5_dev_config': self.new_dev_configuration(Constants.DNF5, Dnf5PackageManager),
8181
'tdnf_dev_config': self.new_dev_configuration(Constants.TDNF, AzL3TdnfPackageManager),
8282
'yum_dev_config': self.new_dev_configuration(Constants.YUM, YumPackageManager),
8383
'zypper_dev_config': self.new_dev_configuration(Constants.ZYPPER, ZypperPackageManager),
8484

8585
'apt_test_config': self.new_test_configuration(Constants.APT, AptitudePackageManager),
86-
'dnf5_test_config': self.new_test_configuration(Constants.DNF, Dnf5PackageManager),
86+
'dnf5_test_config': self.new_test_configuration(Constants.DNF5, Dnf5PackageManager),
8787
'tdnf_test_config': self.new_test_configuration(Constants.TDNF, AzL3TdnfPackageManager),
8888
'yum_test_config': self.new_test_configuration(Constants.YUM, YumPackageManager),
8989
'zypper_test_config': self.new_test_configuration(Constants.ZYPPER, ZypperPackageManager)
@@ -120,7 +120,7 @@ def get_configuration(self, env, package_manager_name):
120120
print ("Error: Environment configuration not supported - " + str(env))
121121
return None
122122

123-
if str(package_manager_name) not in [Constants.APT, Constants.DNF, Constants.TDNF, Constants.YUM, Constants.ZYPPER]:
123+
if str(package_manager_name) not in [Constants.APT, Constants.DNF5, Constants.TDNF, Constants.YUM, Constants.ZYPPER]:
124124
print ("Error: Package manager configuration not supported - " + str(package_manager_name))
125125
return None
126126

src/core/src/bootstrap/Constants.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ class StatusTruncationConfig(EnumBackport):
201201

202202
# Package Managers
203203
APT = 'apt'
204-
DNF = 'dnf5'
204+
DNF5 = 'dnf5'
205205
TDNF = 'tdnf'
206206
YUM = 'yum'
207207
ZYPPER = 'zypper'

0 commit comments

Comments
 (0)