Ut

Author: yashnap

src/core/tests/Test_Dnf5PackageManager.py

@@ -17,7 +17,6 @@
 import os
 import sys
 import unittest
-from unittest.mock import patch
 
 # Conditional import for StringIO
 try:
@@ -29,7 +28,6 @@
 from core.src.bootstrap.Constants import Constants
 from core.tests.library.RuntimeCompositor import RuntimeCompositor
 
-
 class TestDnfPackageManager(unittest.TestCase):
     def setUp(self):
         self.runtime = RuntimeCompositor(ArgumentComposer().get_composed_arguments(), True, Constants.DNF)
@@ -38,20 +36,11 @@ def setUp(self):
     def tearDown(self):
         self.runtime.stop()
 
-    def mock_run_command_output_return_dnf(self, cmd, no_output=False, chk_err=True):
-        """ Mock for run_command_output to return dnf """
-        return 0, "3.5.8-3\n"
-
-    def mock_run_command_output_return_1(self, cmd, no_output=False, chk_err=True):
-        """ Mock for run_command_output to return None """
-        return 1, "No output available\n"
-
     def __assert_std_io(self, captured_output, expected_output=''):
         output = captured_output.getvalue()
         self.assertTrue(expected_output in output)
 
-    # region Mocks
-    def mock_do_processes_require_restart_raise_exception(self):
+    def mock_write_with_retry_raise_exception(self, file_path_or_handle, data, mode='a+'):
         raise Exception
 
     def test_refresh_repo(self):
@@ -466,36 +455,6 @@ def __assert_reverted_automatic_patch_configuration_settings(
         override_content = self.runtime.env_layer.file_system.read_with_retry(override_file)
         self.assertTrue(override_content is not None)
 
-        # download_updates assertions
-        if "download_updates = yes" in config_value_expected:
-            # self.assertTrue("--downloadupdates" in override_content)
-            self.assertFalse("--no-downloadupdates" in override_content)
-
-        elif "download_updates = no" in config_value_expected:
-            # "no" or empty both mean we should not have the positive flag
-            self.assertTrue("--downloadupdates" not in override_content)
-
-        else:
-            self.assertTrue(
-                "--downloadupdates" not in override_content and
-                "--no-downloadupdates" not in override_content
-            )
-
-        # apply_updates assertions
-        if "apply_updates = yes" in config_value_expected:
-           # self.assertTrue("--installupdates" in override_content)
-            self.assertFalse("--no-installupdates" in override_content)
-
-        elif "apply_updates = no" in config_value_expected:
-            # "no" or empty both mean we should not have the positive flag
-            self.assertTrue("--installupdates" not in override_content)
-
-        else:
-            self.assertTrue(
-                "--installupdates" not in override_content and
-                "--no-installupdates" not in override_content
-            )
-
     @staticmethod
     def __capture_std_io():
         # arrange capture std IO
@@ -613,6 +572,13 @@ def test_is_reboot_pending_dnf5(self):
         self.assertTrue(package_manager is not None)
         self.assertFalse(package_manager.is_reboot_pending())
 
+        # Exception Path
+        self.runtime.set_legacy_test_type('HappyPath')
+        package_manager = self.container.get('package_manager')
+        self.assertTrue(package_manager is not None)
+        self.runtime.env_layer.file_system.write_with_retry = self.mock_write_with_retry_raise_exception
+        self.assertRaises(Exception, package_manager.is_reboot_pending())
+
     def test_get_current_auto_os_patch_state_disabled_dnf5(self):
         self.runtime.set_legacy_test_type('SadPath')
 
@@ -945,20 +911,47 @@ def test_set_dnf5_automatic_execstart_flags_exception_handling(self):
         """Test exception handling when override file write fails"""
         self.runtime.set_legacy_test_type('HappyPath')
         package_manager = self.container.get('package_manager')
+        # Mock file_system.write_with_retry to raise exception
+        self.runtime.env_layer.file_system.write_with_retry =  self.mock_write_with_retry_raise_exception
+        self.assertRaises(Exception, package_manager._Dnf5PackageManager__set_dnf5_automatic_execstart_flags,)
+
+    def test_update_os_patch_configuration_sub_setting_exception_handling(self):
+        """Test exception handling when override file write fails"""
+        self.runtime.set_legacy_test_type('HappyPath')
+        package_manager = self.container.get('package_manager')
+        # Mock file_system.write_with_retry to raise exception
+        self.runtime.env_layer.file_system.write_with_retry = self.mock_write_with_retry_raise_exception
+        self.assertRaises(Exception, package_manager.update_os_patch_configuration_sub_setting, )
 
+    def test_backup_image_default_patch_configuration_if_not_exists_exception_handling(self):
+        """Test exception handling when override file write fails"""
+        self.runtime.set_legacy_test_type('HappyPath')
+        package_manager = self.container.get('package_manager')
         # Mock file_system.write_with_retry to raise exception
-        with patch.object(package_manager.env_layer.file_system, 'write_with_retry') as mock_write:
-            mock_write.side_effect = IOError("Permission denied")
+        self.runtime.env_layer.file_system.write_with_retry = self.mock_write_with_retry_raise_exception
+        self.assertRaises(Exception, package_manager.backup_image_default_patch_configuration_if_not_exists, )
 
-            # Should raise exception caught by outer try-except
-            self.assertRaises(Exception, package_manager._Dnf5PackageManager__set_dnf5_automatic_execstart_flags,
-                              download_updates=False, apply_updates=False)
 
     def test_get_package_install_expected_avg_time_in_seconds(self):
         self.runtime.set_legacy_test_type('HappyPath')
         package_manager = self.container.get('package_manager')
         self.assertTrue(package_manager.get_package_install_expected_avg_time_in_seconds(), 90)
 
+    def test_no_op_methods(self):
+        """Test all no-op methods execute without error"""
+        self.runtime.set_legacy_test_type('HappyPath')
+        package_manager = self.container.get('package_manager')
+
+        # These should all execute without raising exceptions
+        package_manager.do_processes_require_restart()
+        package_manager.set_max_patch_publish_date()
+        package_manager.add_arch_dependencies(package_manager, "pkg", "1.0", [], [], [], [])
+        package_manager.set_security_esm_package_status("op", [])
+        package_manager.separate_out_esm_packages([], [])
+
+        self.assertTrue(True)
+
+
 if __name__ == '__main__':
     unittest.main()