tools/prow-job-executor: record the cloud and environment#248
Merged
stevekuznetsov merged 1 commit intoJun 10, 2026
Merged
Conversation
We need this information downstream, and it's easy to record it. Signed-off-by: Steve Kuznetsov <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR extends the tools/prow-job-executor CLI to capture additional execution metadata (Azure cloud + target environment) and propagate it downstream via annotations and logs.
Changes:
- Add
--cloudand--environmentflags (and make them required) to the execute command options. - Record cloud/environment alongside region as
ev2.rollout/*annotations on the job pod spec. - Include cloud/environment in the “Starting Prow job execution” log line.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/prow-job-executor/options.go | Adds cloud/environment flags, validation, and records them as EV2 rollout annotations passed to Gangway. |
| tools/prow-job-executor/main.go | Logs cloud/environment values when starting execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+208
to
211
| // Add cloud, environment, and region as annotations | ||
| annotations[ev2RolloutCloudAnnotation] = o.Cloud | ||
| annotations[ev2RolloutEnvironmentAnnotation] = o.Environment | ||
| annotations[ev2RolloutRegionAnnotation] = o.Region |
abiduke612
approved these changes
Jun 10, 2026
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need this information downstream, and it's easy to record it.