Add RunGenevaAction pipeline step type#244
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for a new RunGenevaAction pipeline step across the Go types, JSON unmarshalling, schema validation, and unit tests.
Changes:
- Introduces
RunGenevaActionStepand registers it under the newRunGenevaActionaction constant. - Extends JSON schema to validate
RunGenevaActionstep shape and required fields. - Adds unit tests covering
RequiredInputs()and well-formedness for the new step type.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pipelines/types/resourcegroup.go | Adds JSON unmarshalling support for RunGenevaAction steps. |
| pipelines/types/pipeline.schema.v1.json | Defines and wires in the runGenevaActionStep schema definition. |
| pipelines/types/common_test.go | Adds test cases for required inputs and well-formedness of the new step. |
| pipelines/types/common.go | Introduces the RunGenevaActionStep type and dependency extraction logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ashishmax31
force-pushed
the
add-run-geneva-action-step
branch
from
25b2deb to
4d4d776
Compare
rachelvweber
reviewed
Jun 1, 2026
rachelvweber
approved these changes
Jun 2, 2026
ashishmax31
force-pushed
the
add-run-geneva-action-step
branch
from
4d4d776 to
c1df967
Compare
Adds a new step type for invoking arbitrary Geneva Actions owned by other teams as part of deployment pipelines, using the existing EV2 Microsoft.Geneva.Actions/OperationExecution extension. Signed-off-by: Ashish <[email protected]>
ashishmax31
force-pushed
the
add-run-geneva-action-step
branch
from
c1df967 to
c4c8861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new step type for invoking Geneva Actions as part of deployment pipelines.
Required for https://redhat.atlassian.net/browse/AROSLSRE-886