feat: add IstioUpgradeStep type for pipeline automation#243
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for an IstioUpgrade pipeline step type and wires it into step JSON unmarshalling.
Changes:
- Introduces a new
IstioUpgradeStepwith JSON fields foraksClusterand optionaldryRun. - Registers
StepActionIstioUpgradein theSteps.UnmarshalJSONaction switch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pipelines/types/resourcegroup.go | Adds IstioUpgrade case so the correct step struct is instantiated during JSON unmarshal. |
| pipelines/types/istio.go | Defines the new IstioUpgrade step action constant and step type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trevorwilliams2025
force-pushed
the
istio-stage-1
branch
from
7f3671b to
848614e
Compare
janboll
reviewed
Jun 2, 2026
Collaborator
|
Reading the doc and looking at established patterns, I would expect an |
janboll
reviewed
Jun 2, 2026
trevorwilliams2025
force-pushed
the
istio-stage-1
branch
from
92a2204 to
1f234ce
Compare
12 tasks
geoberle
approved these changes
Jun 16, 2026
Introduces IstioUpgradeStep in the pipeline types system, enabling a new Go-based Istio upgrade step to be registered and executed within the pipeline framework.
trevorwilliams2025
force-pushed
the
istio-stage-1
branch
from
1f234ce to
17d1c1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers a new
IstioUpgradepipeline step type so the pipeline framework can parse and dispatch it.What this includes
IstioUpgradeSteptype withAKSClusterandDryRunfieldsresourcegroup.goforaction: IstioUpgradeWhat this does NOT include
pkg/istio/)Context
This is inert code until ARO-HCP adds a pipeline entry that uses the
IstioUpgradeaction. The business logic will be added in a later iteration.Testing
go build ./...passesgo test ./...passes