chore(mgmt): remove obsolete PKO cleanup tooling (AROSLSRE-1197)#5693
chore(mgmt): remove obsolete PKO cleanup tooling (AROSLSRE-1197)#5693raelga wants to merge 1 commit into
Conversation
The cleanup-pko EV2 Shell step and its Go helper were a one-time migration to remove orphaned Package Operator resources blocking cluster deletion (PR Azure#5366 hardened it to a built binary). Now that the rollout has completed across all management clusters, remove the dead code: - Drop the cleanup-pko Shell step and its build block from dev-infrastructure/mgmt-pipeline.yaml - Delete the dev-infrastructure/scripts/cleanup-pko-resources module - Remove its go.work and .gitignore entries recreate-system-pool and recreate-broken-pools tooling is untouched.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raelga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Holding until we have validation that the PKO cleanup has completed on all management clusters (int/stage/prod). Removing the rollout step before that is confirmed would strand orphaned PKO resources on any cluster not yet swept. |
There was a problem hiding this comment.
Pull request overview
Removes the now-obsolete “cleanup-pko” management cluster rollout step and its associated one-off Go tooling, reducing dead code in the mgmt EV2 pipeline and workspace module list.
Changes:
- Removed the
cleanup-pkoEV2 Shell step and its build output generation fromdev-infrastructure/mgmt-pipeline.yaml. - Deleted the
dev-infrastructure/scripts/cleanup-pko-resources/Go module (code + tests + go.mod/go.sum). - Removed related workspace and ignore-list entries (
go.work,dev-infrastructure/.gitignore).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.work | Removes the deleted PKO cleanup module from the Go workspace. |
| dev-infrastructure/mgmt-pipeline.yaml | Drops the PKO cleanup binary build and the rollout step that executed it. |
| dev-infrastructure/.gitignore | Removes the ignored PKO cleanup binary path since it no longer exists. |
| dev-infrastructure/scripts/cleanup-pko-resources/main.go | Deletes the obsolete PKO cleanup implementation. |
| dev-infrastructure/scripts/cleanup-pko-resources/main_test.go | Deletes tests for the removed PKO cleanup tool. |
| dev-infrastructure/scripts/cleanup-pko-resources/go.mod | Deletes the standalone module definition for the removed tool. |
| dev-infrastructure/scripts/cleanup-pko-resources/go.sum | Deletes dependency checksums for the removed module. |
AROSLSRE-1197
What
Removes the obsolete one-time PKO (Package Operator) cleanup tooling from the management cluster rollout:
cleanup-pkoEV2 Shell step (and itsTODO) fromdev-infrastructure/mgmt-pipeline.yaml.buildStep(therecreate-system-pool/recreate-broken-poolsbuilds are untouched).dev-infrastructure/scripts/cleanup-pko-resources/Go module.go.workentry and the.gitignorebinary entry.Why
The
cleanup-pkostep and its Go helper were a one-time migration to remove orphaned PKO resources that blocked cluster deletion on MGMT clusters (epic AROSLSRE-782). #5366 hardened it to run as a built Go binary. The step itself carried aTODO: Remove this PKO cleanup step once all management clusters have been cleaned up ([ARO-23308](https://redhat.atlassian.net/browse/ARO-23308)).Now that the rollout has completed across all management clusters, the step runs on every mgmt rollout as dead code. This removes it.
Testing
make validate-changed-config-pipelinespasses.go work syncclean; no module references the deleted path.grep -r cleanup-pkoreturns no matches after the change.Special notes for your reviewer
Warning
/hold — do not merge until we have validation that the PKO cleanup has actually completed on all management clusters (int/stage/prod). Removing the step early would strand orphaned PKO resources on any cluster that has not yet been swept. Lift the hold once that is confirmed.
The unrelated
package-operatorlibrary dependency used bytooling/olm-bundle-repkgis intentionally untouched.PR Checklist