Skip to content

feature: adding GA application id to config#5684

Open
rachelvweber wants to merge 1 commit into
Azure:mainfrom
rachelvweber:rawo/addGaAppIdToConfig
Open

feature: adding GA application id to config#5684
rachelvweber wants to merge 1 commit into
Azure:mainfrom
rachelvweber:rawo/addGaAppIdToConfig

Conversation

@rachelvweber

@rachelvweber rachelvweber commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

ARO-27769

What

Adding empty app id to geneva action config

Why

This unblocks reading geneva actions app id from config for generated geneva actions xmls. The placeholder value will be replaced with a real value in sdp-pipelines

Testing

N/A just adding an empty value to config.

Special notes for your reviewer

PR Checklist

  • PR is scoped to a single task (no mixed concerns)
  • Title follows Conventional Commits format
  • Summary explains the "Why" behind the change
  • Linked to relevant ticket/issue
  • Screenshots included (if graph/UI/metrics changes)
  • Self-reviewed the diff
  • CI/CD checks are passing (ignore Tide)
  • Draft PR used for WIP (if applicable)
  • Commit history is clean (rebased/squashed)
  • Tricky code blocks are commented
  • Specific reviewers tagged
  • All comment threads resolved before merge

Copilot AI review requested due to automatic review settings June 16, 2026 22:16
@openshift-ci openshift-ci Bot requested review from avollmer-redhat and roivaz June 16, 2026 22:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Geneva Actions Entra application ID field to the shared config model so downstream tooling/pipelines can read (and later replace) it when generating Geneva Actions XML configuration.

Changes:

  • Added geneva.actions.application.applicationId to the baseline config defaults.
  • Updated the JSON schema to allow applicationId on the entraApplication object.
  • Re-materialized rendered DEV configs to include the new field in relevant environments/regions.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
config/config.yaml Adds the geneva.actions.application.applicationId default value (placeholder).
config/config.schema.json Extends entraApplication schema to permit applicationId.
config/rendered/dev/pers/westus3.yaml Propagates the new Geneva Actions applicationId field into rendered config.
config/rendered/dev/perf/westus3.yaml Propagates the new Geneva Actions applicationId field into rendered config.
config/rendered/dev/dev/westus3.yaml Propagates the new Geneva Actions applicationId field into rendered config.
config/rendered/dev/cspr/westus3.yaml Propagates the new Geneva Actions applicationId field into rendered config.
config/rendered/dev/ci01/centralus.yaml Propagates the new Geneva Actions applicationId field into rendered config.
config/rendered/dev/ci00/centralus.yaml Propagates the new Geneva Actions applicationId field into rendered config.

Comment thread config/config.yaml
@bennerv

bennerv commented Jun 17, 2026

Copy link
Copy Markdown
Member

/lgtm

Talked with Rachel, the reason we're introducing this in our config (even though it's deployed as part of our pipelines) is because the GA extension is published independently of the deployment into prod and won't have access to the bicep to lookup the appid.

Eventually it would be useful to remove this value and chain it to a bicep lookup but for now this will suffice.

@bennerv

bennerv commented Jun 17, 2026

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bennerv, rachelvweber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants