feature: adding GA application id to config#5684
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a Geneva Actions Entra application ID field to the shared config model so downstream tooling/pipelines can read (and later replace) it when generating Geneva Actions XML configuration.
Changes:
- Added
geneva.actions.application.applicationIdto the baseline config defaults. - Updated the JSON schema to allow
applicationIdon theentraApplicationobject. - Re-materialized rendered DEV configs to include the new field in relevant environments/regions.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| config/config.yaml | Adds the geneva.actions.application.applicationId default value (placeholder). |
| config/config.schema.json | Extends entraApplication schema to permit applicationId. |
| config/rendered/dev/pers/westus3.yaml | Propagates the new Geneva Actions applicationId field into rendered config. |
| config/rendered/dev/perf/westus3.yaml | Propagates the new Geneva Actions applicationId field into rendered config. |
| config/rendered/dev/dev/westus3.yaml | Propagates the new Geneva Actions applicationId field into rendered config. |
| config/rendered/dev/cspr/westus3.yaml | Propagates the new Geneva Actions applicationId field into rendered config. |
| config/rendered/dev/ci01/centralus.yaml | Propagates the new Geneva Actions applicationId field into rendered config. |
| config/rendered/dev/ci00/centralus.yaml | Propagates the new Geneva Actions applicationId field into rendered config. |
|
/lgtm Talked with Rachel, the reason we're introducing this in our config (even though it's deployed as part of our pipelines) is because the GA extension is published independently of the deployment into prod and won't have access to the bicep to lookup the appid. Eventually it would be useful to remove this value and chain it to a bicep lookup but for now this will suffice. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennerv, rachelvweber The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ARO-27769
What
Adding empty app id to geneva action config
Why
This unblocks reading geneva actions app id from config for generated geneva actions xmls. The placeholder value will be replaced with a real value in sdp-pipelines
Testing
N/A just adding an empty value to config.
Special notes for your reviewer
PR Checklist