Skip to content

Fix kubeadm E2E bootstrap group#202

Merged
bcho merged 5 commits into
mainfrom
kubeadm-e2e-bootstrap-group
Jun 26, 2026
Merged

Fix kubeadm E2E bootstrap group#202
bcho merged 5 commits into
mainfrom
kubeadm-e2e-bootstrap-group

Conversation

@bcho

@bcho bcho commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

  • include the kubeadm default bootstrap group in kubeadm E2E RBAC bindings
  • include the kubeadm default bootstrap group in the kubeadm E2E bootstrap token
  • fixes kubeadm E2E nodes failing to create kubelet client CSRs with Unauthorized

Validation

@bcho bcho marked this pull request as ready for review June 19, 2026 23:45
Copilot AI review requested due to automatic review settings June 19, 2026 23:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the kubeadm-based E2E node join flow to include kubeadm’s default bootstrap group in both the RBAC bindings and the bootstrap token’s auth-extra-groups, addressing Unauthorized errors when kubeadm E2E nodes attempt to create kubelet client CSRs.

Changes:

  • Introduce a single constant for kubeadm’s default bootstrap group (system:bootstrappers:kubeadm:default-node-token).
  • Add that group to all kubeadm E2E bootstrap-related RBAC subject lists alongside system:bootstrappers:aks-flex-node.
  • Emit both groups in the created bootstrap token Secret via auth-extra-groups.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings June 20, 2026 02:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/e2e-tests.yml Outdated
Comment thread hack/e2e/lib/common.sh
@bcho bcho temporarily deployed to e2e-testing June 26, 2026 22:38 — with GitHub Actions Inactive
@bcho bcho merged commit 2cfcb4e into main Jun 26, 2026
9 checks passed
@bcho bcho deleted the kubeadm-e2e-bootstrap-group branch June 26, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants