Fix My Jetpack route crash in Chrome (And Protect)

[dereksmart]

Fixes: p1783960683602709-slack-C0299DMPG

Summary

• Prevent the My Jetpack and Protect plugin ScrollToTop effect from returning the result of window.scrollTo().
• Avoid React treating Chromium scroll API promises as effect cleanup callbacks on route changes.

Causes a blank page.

Why this happens in Chrome

ScrollToTop used a concise arrow effect: useEffect( () => window.scrollTo( 0, 0 ), [ location ] ). React treats any value returned from an effect callback as that effect cleanup. In Firefox, window.scrollTo( 0, 0 ) returns undefined, so there is no cleanup. In Chrome/Chromium, the same call can return a Promise; React stores that promise as the cleanup value and then tries to call it during the next route change/unmount. Because the promise is not a function, React throws from its effect cleanup path, which leaves the My Jetpack admin page blank.

The fix keeps the scroll behavior but uses a block body so the effect callback returns undefined consistently across browsers.

Testing instructions:

• In Chrome
• Click on top-level jetpack admin menu item
• Click on all of these tabs:

Does this pull request change what data or activity we track or use?

No

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the codex/fix-my-jetpack-scrollto-effect branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack codex/fix-my-jetpack-scrollto-effect

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/my-jetpack/_inc/admin.jsx	0/16 (0.00%)	0.00%	1 ❤️‍🩹

Full summary · PHP report · JS report

[anomiex]

Looks reasonable. Fixes the issue on the JN site I was using for reproduction.