Forms: remove dependency to @automattic/calypso-color-schemes

[simison]

In preparation for improving WPDS CSS token build pipelines in Jetpack (#50108), I'm removing the few dependencies in old Calypso color schemes package.

Proposed changes

Replaced the error notice with the Notice component instead of a custom-made one.

Removed Gridicons dependency also now as unused in Forms.

Upsell styles at projects/packages/forms/src/blocks/shared/components/upsell-nudge/style.scss I'm removing entirely — they're loosely coupled overrides for the Jetpack component styles which in turn override some core component styles. The Jetpack form-specific styles don't seem to be actually doing anything (at least that I can see).

The errors could actually use the Notice component now and form field invalid message later once its available, instead of a custom-made thingy with an old Gridicon, but that's a separate worry. :-)

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Build forms jetpack build packages/forms

In the editor, test 3 things with Form block:

• Upsell banner for file upload field
  

• Error for invalid emails in the block settings sidebar

  

• Error for invalid API key for Salesforce integration
  

Screenshots before:

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/forms-remove-calypso-color-schemes branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-remove-calypso-color-schemes

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/forms-remove-calypso-color-schemes

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[simison]

Slider field is also affected, but I'm not able to get the input to "error" state in other than adding the classname manually and even then the outline style isn't taking effect so it's probably dead code:

[enejb]

Works as expected! Thanks for the fixes @simison