Launchpad: remove the deprecated start-writing checklist#50432
Draft
taipeicoder wants to merge 3 commits into
Draft
Launchpad: remove the deprecated start-writing checklist#50432taipeicoder wants to merge 3 commits into
taipeicoder wants to merge 3 commits into
Conversation
The start-writing flow is retired end to end: Calypso no longer routes into it, and wpcom no longer reads its checklist or runs its onboarding email campaign. Remove the checklist and the branches that remained for it: the blog_launched gating, the site launch cleanup arm, and the tailored email trigger. Each falls through to the behavior every other site intent already gets, and design-first keeps its own handling untouched. The retired-intent cleanup added earlier stays. It is the only thing that still clears site_intent for sites left on the flow, and it no longer depends on the checklist existing. The endpoint test's checklist_slug fixture moves to design-first, since an unregistered slug is now rejected by the REST arg schema before the use_goals flag is consulted. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
github-actions
Bot
added
[mu wpcom Feature] Launchpad
[Package] Jetpack mu wpcom
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 4 files.
|
Removing the checklist also drops the slug from the endpoint's checklist_slug enum, so a request that passes it explicitly gets a 400 during argument validation. Calypso still builds those requests from cached site_intent, and the full Launchpad reads that 400 as a fetch failure and redirects to /home. Keep the retired slugs in the enum, sourced from the same list the site-intent cleanup uses, so a stale request degrades to an empty checklist and the cleared state instead of erroring. Covered by a regression test asserting the explicit slug returns 200. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
A site's wpcom_launchpad_config can still name a retired checklist as its active_checklist_slug, from before the checklist was unregistered. The getter returned it verbatim, so the Navigator reported a current checklist that no longer exists while the available list, which filters unregistered slugs, showed nothing. Validate the stored slug against the registered checklists in the getter, matching what the available list already does and what the setter already enforces. This is a read-time repair, so it also covers sites whose site_intent was cleared earlier and would be missed by an intent-gated fix. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # N/A
Proposed changes
start-writingLaunchpad checklist. Its task set is a strict subset of thedesign-firstchecklist, so no task definitions are orphaned.blog_launchedgating, the site launch cleanup arm, and the tailored onboarding email trigger. Each now falls through to the behavior every other site intent already gets, anddesign-firstkeeps its own handling untouched.wpcom_launchpad_clear_retired_site_intents) added earlier. It is the only thing that still clearssite_intentfor sites left on the flow, and it does not depend on the checklist existing.This is the final jetpack piece of the start-writing deprecation. Calypso has removed the flow and its routing, and wpcom has removed its checklist reads and onboarding email campaign, so nothing downstream reads this checklist anymore.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No. The tailored onboarding email campaign was already unreachable for this intent, since no site is created under the flow.
design-firstis unchanged.Testing instructions
site_intentset todesign-first, confirm nothing changed:site_intentand turns the Launchpad screen off, and the tailored onboarding email still triggers.site_intentset tostart-writing, confirm it degrades cleanly:site_intentand turns the Launchpad screen off on the next request.