VideoPress caption manager: preview the cue being edited#50428
Open
obenland wants to merge 1 commit into
Open
Conversation
The preview overlay was purely time-gated, showing a cue only when the playhead fell inside its [start, end) window. A cue created at the playhead spans just two seconds, so while the video played the playhead left that window before the author could type, and the new cue never previewed (it only appeared once the video was stopped inside the range). Overlay the focused cue's live text in place of the playhead cue while a cue field holds focus, reverting to time-synced captions once focus leaves the editor. This shows the cue you are editing whether the video is playing or paused, including with "Pause while typing" enabled. Claude-Session: https://claude.ai/code/session_01A7Ft9CRq2JHuEJoUFU3MMm
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 2 files.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
[start, end)window. A cue created at the playhead spans just two seconds, so while the video played the playhead left that window before you could type, and the new cue never previewed (it appeared only when the video was stopped inside the range).CaptionPreviewPlayerfor the edited-cue override, the empty-cue case, live text updates, and the fallback to time-synced captions, plus a full-modal integration test that types a cue, moves the playhead past its window, asserts the overlay stays, then blurs and asserts it reverts.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Cshortcut or the add-subtitle button) and start typing its text.https://claude.ai/code/session_01A7Ft9CRq2JHuEJoUFU3MMm