Social logos: prefix token names & use as dependency around the repo

[simison]

Prep work for removing inlining var() tokens in #50108

Proposed changes

• Prefix color tokens from --color-bluesky → --jetpack-social-logo-color-bluesky etc

Currently, in the webpack build pipeline (excluding wp-build pages) we inline tokens (color: var( --color-foo ) becomes color: #000), and the tokens are added from @automattic/calypso-color-schemes as part of the build process:

jetpack/projects/packages/publicize/postcss.config.js

Lines 3 to 18 in 6e1fbd2

	require( '@csstools/postcss-global-data' )( {
	// Provide the properties that postcss-custom-properties is going to work with.
	files: [ require.resolve( '@automattic/calypso-color-schemes/root-only/index.css' ) ],
	} ),
	require( 'postcss-custom-properties' )( {
	// Use of `preserve: false` dates back to when we still used @automattic/calypso-build.
	// Ideally we'd get rid of it to properly make use of CSS vars, but first we have to
	// figure out how to ensure the vars actually get defined in the browser without
	// including them in every bundle. Some base stylesheet (wp_register_style) the other
	// stylesheets depend on maybe? And also deal with extremely generic vars like "--color-text".
	//
	// See also https://github.com/Automattic/jetpack/pull/13854#issuecomment-550898168,
	// where people were confused about what was going on when calypso-build stopped
	// including a postcss.config.js like this by default.
	preserve: false,
	} ),

This was mostly done for backwards compatibility with old browsers. When switching to use WPDS tokens, we should preserve var() in the CSS and add fallbacks instead as part of the build-process, resulting in: color: var( --color-foo, #000 )

This PR will do a couple of things in preparation for the above:

• Decouple social color dependency in @automattic/calypso-color-schemes and explicitly import these colors only from social-logos package everywhere.
• Once variables are plain text and in the global scope (not yet in this PR, but in future), --color-* in WP admin context is a bit too generic and risks conflicting with other plugins; hence new prefix.

I'm also:

• Switching one $whatsapp sass variable to use the CSS token instead.
• Using CSS token instead of fixed color for share-x class in sharing buttons block style

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Smoke test affected UIs:

• Publicize "Add service"
• Sharing buttons

[simison]

Simply moved these down to group selectors using tokens from the rest.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/social-prefix-color-tokens branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/social-prefix-color-tokens

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/social-prefix-color-tokens

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[simison]

Replaced #000 with --jetpack-social-logo-color-x for X.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[simison]

Using shared --jetpack-social-logo-color-whatsapp instead of fixed $whatsapp

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report