Skip to content

pnpm: Exclude 'gridicons' in minimum relase age limit#50408

Merged
simison merged 1 commit into
trunkfrom
update/pnpm-config-gridicons
Jul 10, 2026
Merged

pnpm: Exclude 'gridicons' in minimum relase age limit#50408
simison merged 1 commit into
trunkfrom
update/pnpm-config-gridicons

Conversation

@simison

@simison simison commented Jul 10, 2026

Copy link
Copy Markdown
Member

Gridicons is our own package so we can update it right away without limits:

Follow-up to #50407 (comment)

@simison simison requested a review from a team as a code owner July 10, 2026 14:01
@simison simison added [Status] Needs Review This PR is ready for review. Build Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. labels Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/pnpm-config-gridicons branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/pnpm-config-gridicons
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/pnpm-config-gridicons

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Jul 10, 2026
@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@anomiex anomiex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 I won't be surprised if the next update is for React 20 in a few years, though.

@simison simison merged commit 6e1fbd2 into trunk Jul 10, 2026
103 of 104 checks passed
@simison simison deleted the update/pnpm-config-gridicons branch July 10, 2026 14:38
@github-actions github-actions Bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants