Skip to content

Premium Analytics: add forced Loading/Error/Empty Storybook stories for migrated widgets#50391

Draft
chihsuan wants to merge 5 commits into
wooa7s-1675-migrate-existing-widgets-to-widgetstate-forfrom
wooa7s-1675-forced-state-stories
Draft

Premium Analytics: add forced Loading/Error/Empty Storybook stories for migrated widgets#50391
chihsuan wants to merge 5 commits into
wooa7s-1675-migrate-existing-widgets-to-widgetstate-forfrom
wooa7s-1675-forced-state-stories

Conversation

@chihsuan

@chihsuan chihsuan commented Jul 10, 2026

Copy link
Copy Markdown
Member

Proposed changes

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Build Storybook and open Packages > Premium Analytics > Widgets.
  • Check a few Loading, Error, and Empty stories, e.g. WordAdsChartTabs, Search terms, and Store performance.
  • Confirm Default / WithComparison stories still render populated.
Screen.Recording.2026-07-13.at.5.36.04.PM.mov

@jp-launch-control

jp-launch-control Bot commented Jul 10, 2026

Copy link
Copy Markdown

Code Coverage Summary

No summary data is available for parent commit 87dcbb5, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 87dcbb5 is available.

Full summary · PHP report

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 10, 2026
@chihsuan chihsuan force-pushed the wooa7s-1675-migrate-existing-widgets-to-widgetstate-for branch from 154e20b to e4c7536 Compare July 10, 2026 08:42
@chihsuan chihsuan force-pushed the wooa7s-1675-forced-state-stories branch from 7601ca8 to 4d9fcee Compare July 10, 2026 09:48
@chihsuan chihsuan force-pushed the wooa7s-1675-forced-state-stories branch 6 times, most recently from 798d625 to 6be93c1 Compare July 13, 2026 10:31
@chihsuan chihsuan force-pushed the wooa7s-1675-forced-state-stories branch from 6be93c1 to 5d22dc7 Compare July 13, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs [Package] Premium Analytics [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant