renovate: Pin all actions#49557
Conversation
PR #49456 set up renovate to pin all actions except `actions/*`. It has now come out that they intend to turn on GitHub's "require actions to be pinned" setting, which does not make an exception for those. We may as well get ahead of things and update renovate now.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
tbradsha
left a comment
tbradsha
left a comment
There was a problem hiding this comment.
Seems reasonable. Let's give it a go.
| matchDepTypes: [ 'action' ], | ||
| matchUpdateTypes: [ 'minor', 'patch', 'pin', 'digest' ], | ||
| matchPackageNames: [ '!actions/**' ], | ||
| matchUpdateTypes: [ 'minor', 'patch', 'pin', 'digest', 'pinDigest' ], |
There was a problem hiding this comment.
Took me a bit to figure this one out; it seems pinDigest is needed to switch things from non-digest to digest?
There was a problem hiding this comment.
More that "pinDigest" is what renovate sets the type to when switching things from non-digest to digest. Leaving it out makes it not match the grouping rule, so each package would get separate PRs instead (unless grouped by some other rule).
github-actions
Bot
removed
the
[Status] Needs Review
2 participants
Proposed changes
PR #49456 set up renovate to pin all actions except
actions/*. It has now come out that they intend to turn on GitHub's "require actions to be pinned" setting, which does not make an exception for those. We may as well get ahead of things and update renovate now.Related product discussion/links
DEVPROD-1072#comment-440d38ac
Does this pull request change what data or activity we track or use?
No
Testing instructions
Run renovate using this branch and see what happens?Merge in a fork and run renovate there.