quote handling#19
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address issue #16 (“improper quotation handling for athena files”) by making quote handling explicit/consistent across the PostgreSQL COPY fast-path and the pandas fallback, and by adding tests that exercise literal vs CSV quoting behavior.
Changes:
- Added
resolve_quote_mode()and used it in bothquick_load_pg()and the pandas fallback loader to ensure consistent parsing behavior. - Expanded test coverage for quote-mode propagation and delimiter-derived quote-mode selection.
- Bumped project version to
0.5.2and updated thepyarrowminimum requirement / lockfile.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/orm_loader/loaders/loading_helpers.py |
Adds resolve_quote_mode() and routes COPY quote behavior through it; increases infer sampling size. |
src/orm_loader/loaders/loader_interface.py |
Ensures pandas fallback honors resolved quote mode via quoting=. |
tests/loaders/test_helpers.py |
Adds unit tests for resolve_quote_mode() and existing sniffing behavior. |
tests/loaders/test_pandas_loader.py |
Adds integration tests proving quote_mode affects pandas parsing and delimiter-derived behavior. |
pyproject.toml |
Version bump and dependency floor update for pyarrow. |
uv.lock |
Lockfile updates reflecting version/dependency changes (including pyarrow resolution). |
CHANGELOG.md |
Adds a 0.5.2 entry for quote-handling changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix #16