Skip to content

fix(api): deterministic seed for collaborator notification test (flaky on main) #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raymondjacobson merged 1 commit into from
Jun 9, 2026
+9 −2
Merged

fix(api): deterministic seed for collaborator notification test (flaky on main) #943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions api/v1_track_collaborators_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"fmt"
"testing"
"time"

"api.audius.co/api/dbv1"
"api.audius.co/database"
Expand All @@ -14,9 +15,15 @@ import (
// seedCollaborators adds: user 1 accepted on track 700 (owned by user 500) and
// user 1 pending on track 701 (owned by user 500).
func seedCollaborators(t *testing.T, app *ApiServer) {
// created_at must equal updated_at so the notification trigger's "new pending
// invite" branch fires (it mirrors the ETL, which writes them equal on
// insert). The seed baseRow's defaults call time.Now() twice, which only
// round-trip equal when both calls land in the same microsecond — a flaky
// coin flip. Pin a single value for both.
now := time.Now()
database.SeedTable(app.pool.Replicas[0], "track_collaborators", []map[string]any{
{"track_id": 700, "collaborator_user_id": 1, "invited_by": 500, "status": "accepted"},
{"track_id": 701, "collaborator_user_id": 1, "invited_by": 500, "status": "pending"},
{"track_id": 700, "collaborator_user_id": 1, "invited_by": 500, "status": "accepted", "created_at": now, "updated_at": now},
{"track_id": 701, "collaborator_user_id": 1, "invited_by": 500, "status": "pending", "created_at": now, "updated_at": now},
})
}

Expand Down
Loading