Skip to content

Fix leak in closures with circular references #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SuperFola merged 3 commits into from
Jul 7, 2026
Merged

Fix leak in closures with circular references #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bc89df
refactor(vm): move include where they are needed
SuperFola Jul 6, 2026
37641ce
chore: add missing include for std::get_time on debian
SuperFola Jul 6, 2026
8fc1120
chore(ci): ignore leaks when copying a ClosureScope
SuperFola Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,14 +461,16 @@ jobs:

- name: Run tests
run: |
# we are in /home/runner/work/Ark/Ark/build/
export ASAN_OPTIONS=detect_odr_violation=0
export LSAN_OPTIONS=suppressions=../lsan-suppressions.txt
./build/unittests

- name: Gather coverage
run: cmake --build build --target coverage

- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@main
with:
path-to-lcov: build/coverage.info
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -503,6 +505,7 @@ jobs:
shell: bash
run: |
export ASAN_OPTIONS=detect_odr_violation=0
export LSAN_OPTIONS=suppressions=lsan-suppressions.txt
./unittests

- uses: actions/setup-python@v6
Expand All @@ -515,6 +518,7 @@ jobs:
shell: bash
run: |
export ASAN_OPTIONS=detect_odr_violation=0
export LSAN_OPTIONS=suppressions=lsan-suppressions.txt
chmod u+x ./lib/modules/.github/run-tests
(./lib/modules/.github/run-tests src)

Expand Down Expand Up @@ -695,4 +699,6 @@ jobs:
--verbose -s \
--demangle=yes \
--error-exitcode=1 \
--suppressions=valgrind-suppressions.txt \
--gen-suppressions=all \
build/arkscript -L ./lib tests/unittests/resources/LangSuite/unittests.ark valgrind
10 changes: 1 addition & 9 deletions include/Ark/VM/VM.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,15 @@
#include <vector>
#include <string>
#include <ranges>
#include <cassert>
#include <utility>
#include <cinttypes>
#include <unordered_map>
#include <algorithm>
#include <fmt/core.h>
#include <fmt/ranges.h>

#include <Ark/Compiler/Instructions.hpp>
#include <Ark/VM/Value/Value.hpp>
#include <Ark/State.hpp>
#include <Ark/VM/ScopeView.hpp>
#include <Ark/VM/ErrorKind.hpp>
#include <Ark/VM/ExecutionContext.hpp>
#include <Ark/Builtins/Builtins.hpp>
#include <Ark/Utils/Platform.hpp>
#include <Ark/Utils/Literals.hpp>
#include <Ark/VM/SharedLibrary.hpp>
#include <Ark/VM/Value/Future.hpp>
#include <Ark/VM/Debugger.hpp>
Expand Down Expand Up @@ -429,8 +421,8 @@ namespace Ark
*/
void backtrace(internal::ExecutionContext& context, std::ostream& os = std::cerr, bool colorize = true);
};
}

#include "VM.inl"
}

#endif
Loading
Loading