refactor: source protobuf descriptors from command codecs#911
Draft
ryanditjia wants to merge 4 commits into
Draft
refactor: source protobuf descriptors from command codecs#911ryanditjia wants to merge 4 commits into
ryanditjia wants to merge 4 commits into
Conversation
Review point: Replace lazy sync.Once descriptor construction and the hand-built dynamic protobuf test fixture. Change: Finalize the catalog before service startup, reject late registration, and use a generated protobuf command fixture with a Taskfile generation command. Verification: task lint; go test ./pkg/cardinal/...; go test -race ./pkg/cardinal; buf lint; task generate:commandtest-proto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToProtofrom Cardinal introspectionFileDescriptorSet, and cache its bytesWhy
This keeps wire metadata attached to the codec that actually owns serialization. It avoids inferring message types through reflection and leaves the descriptor collector reusable when components and events migrate to protobuf.
Stacked on #909.
Validation
task lintpkg/cardinaldescriptor tests