Update packages#248
Merged
Merged
Conversation
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
There was a problem hiding this comment.
Pull request overview
Updates build configuration to refresh dependency/plugin versions and reduce distribution size by excluding additional jars during packaging.
Changes:
- Bump
sbt-wartremoverplugin from3.5.7to3.5.8. - Update
chenVersionfrom2.5.20to2.5.22. - Add a Google Maven resolver and expand the list of excluded jars for the Universal distribution mappings.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| project/plugins.sbt | Updates the WartRemover sbt plugin version. |
| build.sbt | Updates chen version, adds Google Maven resolver, and expands packaging exclusions to trim distribution contents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Prabhu Subramanian <[email protected]>
Contributor
Author
|
@copilot AI is ill-suited for such reviews and is, in fact, lying confidently. This PR excludes a bunch of new jars. Human reviewers would have either waited for the build/tests to finish or checked the dependencies for chen to identify any legitimate dependencies being ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trim unwanted packages