feat: Adopt AGP v9

[hurali97]

Summary

Note: Merge this PR after #732

This PR is rasied following the second phase of the RFC around AGP v9 adoption:

RFC: react-native-community/discussions-and-proposals#1006

The gist of this PR is to make Gesture Handler AGP v9 compliant with backward compatibility. The main scope of changes is the react-native-safe-area-context/android/build.gradle. The rest of the changes can be considered temporary.

The rest changes include:

• Making Example App AGP9 compliant
• Upgrade Gradle to v9.4.1
• Enable opt outs in the gradle.properties

Ideally, we should not enable the opt outs and leverage the AGP 9 built-in kotlin and newDSL. However, if we do not do it, then other libraries which are not yet AGP v9 compliant starts to fail. Hence, we need to keep the opt outs enabled for a while. For the context, react-native starting from 0.87.x will ship with AGP v9 and opt outs enabled by default for the new apps, which is the first phase of AGP v9 adoption.

With the second phase when the libraries starts adoption AGP v9, we can eventually remove the opt outs from Example.

Test Plan

To test this PR, we need to do a few steps:

• Set the agp version to 9.2.1 and kotlin to 2.2.0 in react-native-gradle-plugin

--- a/node_modules/@react-native/gradle-plugin/gradle/libs.versions.toml
+++ b/node_modules/@react-native/gradle-plugin/gradle/libs.versions.toml
@@ -1,10 +1,10 @@
 [versions]
-agp = "8.12.0"
+agp = "9.2.1"
 gson = "2.8.9"

-kotlin = "2.1.20"
+kotlin = "2.2.0"
 assertj = "3.25.1"

• Comment out the following functions in react-native-gradle-plugin

--- a/node_modules/@react-native/gradle-plugin/react-native-gradle-plugin/ReactPlugin.kt
+++ b/node_modules/@react-native/gradle-plugin/react-native-gradle-plugin/ReactPlugin.kt
@@ -1,10 +1,10 @@
      configureBuildTypesForApp(project)
    }

    // Library Only Configuration
-    configureBuildConfigFieldsForLibraries(project)
-    configureNamespaceForLibraries(project)
+    // configureBuildConfigFieldsForLibraries(project)
+    // configureNamespaceForLibraries(project)
    project.pluginManager.withPlugin("com.android.library") {

This step is only required because we have RN version on 0.85.2 and AGP + kotlin bump will be shipped with 0.87.x.

Verified by locally patching RN screens, async-storage etc., making those AGP v9 compliant and removing the opt outs to test the changes in the PR

agp-9.mov

Verified these changes work with AGP 8

agp-8.mov

[hurali97]

Added comments on the files which targets the scope of this PR, the rest changes will be gone once the linked PR is merged.

[MeliValesca]

Hello :D Since the other PR was fixed and merged can you maybe update this with just the 2 changes and retest that everything works fine ? @hurali97

[hurali97]

This change is required as we bumped Gradle version in example app. React Native core defaults to this kotlin version from RN 0.87.x. RN Core also defaults to Gradle version 9.4.1 from RN 0.87.x

[hurali97]

@MeliValesca - Synced the PR with the latest main and tested on:

Example App

rnsa.mov

RN v0.86.0 App which defaults to AGP 8

RNapp.mov

Regarding the failing test, it happens because I have bumped the spotless plugin and now formatting doesn't align with the latest. Even though bumping spotless plugin is not required, I did it for the latest behavior's sake.

Let me know if you'd like for this change to be dropped OR if we can accept the bump, we need to run gradlew spotlessApply and commit the resulting diff.

[janicduplessis]

Let me know if you'd like for this change to be dropped OR if we can accept the bump, we need to run gradlew spotlessApply and commit the resulting diff.

You can keep the change and commit the formatting diff, thanks!