feat: add Jetson Xavier unified memory detection#146
Open
hernandez42 wants to merge 1 commit into
Open
Conversation
Add Xavier family markers (AGX Xavier, Xavier NX) to _NVIDIA_UNIFIED_MEMORY_MARKERS so whichllm correctly detects NVIDIA GPUs on Jetson Xavier platforms that use unified memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Xavier family markers to
_NVIDIA_UNIFIED_MEMORY_MARKERSsowhichllmcorrectly detects NVIDIA GPUs on Jetson Xavier platforms that use unified memory.Changes
src/whichllm/hardware/nvidia.py"JETSON AGX XAVIER","JETSON XAVIER NX", and"XAVIER"to the unified memory marker tupleProblem
Jetson AGX Xavier and Xavier NX devices were not detected as having a GPU because their hardware names weren't in the unified memory detection list.
whichllmwould report no GPU found even though the device has a Maxwell GPU with unified memory.Solution
Extended the marker list to cover all Xavier variants, matching the existing pattern used for Orin (GB10, DGX SPARK).
Testing
On a Jetson AGX Xavier or Xavier NX device:
Should now show the GPU model and unified memory size instead of 'No GPU detected'.