Skip to content

Polish sidebar transitions and search dismissal - #71

Merged
Andresshamis merged 1 commit into
mainfrom
codex/sidebar-search-dismissal-main
Jul 29, 2026
Merged

Polish sidebar transitions and search dismissal#71
Andresshamis merged 1 commit into
mainfrom
codex/sidebar-search-dismissal-main

Conversation

@Andresshamis

Copy link
Copy Markdown
Owner

What changed

  • dismiss the command bar when the sidebar is pressed or a tab/space is selected
  • keep the sidebar action active on the same click
  • add a compositor-only emphasis transition while paging between spaces
  • cover command-bar dismissal and page-transition behavior with regression tests

Why

The command-bar backdrop deliberately passed sidebar clicks through, while New Tab mode was preserved during space selection and tab selection did not dismiss the bar. This left the search interface open after users returned to the sidebar.

The page treatment also gives outgoing and incoming sidebar spaces a subtle, symmetric transition without publishing scroll geometry through SwiftUI.

Validation

  • swift build
  • swift test — 465 tests passed
  • bash -n script/build_and_run.sh
  • git diff --check

@Andresshamis
Andresshamis enabled auto-merge (squash) July 29, 2026 20:09
@Andresshamis
Andresshamis merged commit 911fb71 into main Jul 29, 2026
1 check passed
@Andresshamis
Andresshamis deleted the codex/sidebar-search-dismissal-main branch July 29, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant