[codex] Open external links in existing window tabs - #65
Merged
Andresshamis merged 1 commit intoJul 24, 2026
Merged
Conversation
Avesceb
marked this pull request as ready for review
July 24, 2026 20:03
Andresshamis
pushed a commit
that referenced
this pull request
Jul 28, 2026
Co-authored-by: Andres Vesce <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Lumen is registered for
httpandhttpsURLs, clicking a link in another app routes the event to Lumen. The existingWindowGroupdid not declare that an open scene should handle external events and did not consume the incoming URL. SwiftUI therefore created another browser window, while the requested page never reached the browser store.For users, this made links from apps such as Excel and Numbers effectively impossible to open in Lumen.
Root cause
The generated application bundle did not consistently declare the web URL schemes, and the main browser view had neither an external-event preference nor an
onOpenURLhandler. With a multi-windowWindowGroup, an unclaimed event is routed to a newly created scene.Fix
The generated
Info.plistnow declares Lumen as a viewer for thehttpandhttpsURL schemes.The main browser view now:
BrowserStore.open, which creates and selects a new tab using the existing navigation and URL security policies.If Lumen has no open scene, SwiftUI can still create the browser scene and deliver the URL to the same handler.
Validation
swift test— 425 tests passed with 0 failures.bash -n script/build_and_run.shgit diff --check