Skip to content

fix: pin release-v0.8.5 gate to constant version (unblocks all PRs)#923

Merged
anandgupta42 merged 1 commit into
mainfrom
fix/stale-release-gate-0.8.5
Jun 10, 2026
Merged

fix: pin release-v0.8.5 gate to constant version (unblocks all PRs)#923
anandgupta42 merged 1 commit into
mainfrom
fix/stale-release-gate-0.8.5

Conversation

@anandgupta42

@anandgupta42 anandgupta42 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes a stale release-gate test that is broken on main and blocks every current PR (observed on #918 and #854).

release-v0.8.5-adversarial.test.ts → "docs point at the action patch…" derived the version from the CHANGELOG's top entry and asserted it equals hardcoded "0.8.5". Once 0.8.6 shipped, the top entry became 0.8.6 → the assertion permanently fails (Expected "0.8.5", Received "0.8.6"). Only the 0.8.5 gate has this pattern (0.8.6's does not).

The 0.8.5 gate is release-specific (docs must reference the patched @v0.8.5, not the broken @v0.8.4). Fix: pin to the constant "0.8.5" and assert that changelog entry exists rather than that it is the latest. The docs assertions are unchanged and already pass.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Issue for this PR

Closes #922

How did you verify your code works?

  • release-v0.8.5-adversarial.test.ts now passes (13/13; was failing on the version assertion).
  • Confirmed the breakage is pre-existing on main (independent of feature work) and that only the 0.8.5 gate uses the changelog-top pattern.
  • Marker guard clean (test-only change).

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have added tests that prove my feature works
  • New and existing unit tests pass locally with my changes

Summary by cubic

Pin the v0.8.5 release-gate test to "0.8.5" and assert the changelog entry exists, fixing a failure on main and unblocking all PRs.

  • Bug Fixes
    • Stop deriving the version from the CHANGELOG’s top entry; use "0.8.5" and check for ## [0.8.5].
    • Keep the docs checks as-is to ensure they reference @v0.8.5 (not @v0.8.4).

Written for commit c01e0ba. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Tests
    • Updated test verification for changelog entries to explicitly validate version-specific header presence in documentation.

…ry later release)

The "docs point at the action patch" test derived `version` from the CHANGELOG's
top entry and asserted it equals "0.8.5". After 0.8.6 shipped, the top entry moved
to 0.8.6, so the assertion permanently failed — broken on main, blocking every PR
(seen on #918, #854). Only the 0.8.5 gate had this pattern.

This gate is specific to the 0.8.5 release (docs reference the patched @v0.8.5, not
the broken @v0.8.4). Pin to the constant "0.8.5" and assert that changelog entry
EXISTS rather than that it is the latest. Docs assertions unchanged (and passing).

Closes 922

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cbf89458-8258-4958-9ec3-27cb5f4b2977

📥 Commits

Reviewing files that changed from the base of the PR and between c2019ba and c01e0ba.

📒 Files selected for processing (1)
  • packages/opencode/test/skill/release-v0.8.5-adversarial.test.ts

📝 Walkthrough

Walkthrough

The PR fixes a stale release gate test in the v0.8.5 adversarial test suite. The test previously extracted the top changelog version and compared it to "0.8.5", which fails whenever newer versions ship. It now directly asserts the changelog contains a ## [0.8.5] entry.

Changes

v0.8.5 Release Gate Stability

Layer / File(s) Summary
Changelog version assertion fix
packages/opencode/test/skill/release-v0.8.5-adversarial.test.ts
Test hardcodes version to "0.8.5" and asserts that CHANGELOG.md contains the literal header ## [0.8.5] instead of parsing the top entry, removing the blocking failure that occurred when newer versions were released.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Suggested labels

contributor

Poem

🐰 A changelog once broke with every release,
No more—pin the version and find peace!
O.8.5 stays fixed, the test now runs clean,
No stale gates to block the continuous stream. 🌱

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is comprehensive, but it does not include the required 'PINEAPPLE' marker at the top as mandated by the template for AI-generated contributions. Add 'PINEAPPLE' at the very top of the PR description before any other content, as required by the template for AI-generated contributions.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: pinning the release-v0.8.5 test to a constant version to unblock PRs.
Linked Issues check ✅ Passed The PR successfully addresses all requirements from issue #922: it pins the v0.8.5 test to constant version '0.8.5', asserts the changelog entry exists rather than being latest, and preserves docs assertions.
Out of Scope Changes check ✅ Passed The PR only modifies the release-v0.8.5 test file, making changes directly aligned with fixing the stale release gate issue; no out-of-scope changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stale-release-gate-0.8.5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@anandgupta42 anandgupta42 merged commit 5c1fedf into main Jun 10, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale release gate: release-v0.8.5 test pins to changelog top, breaks on every later release

1 participant