fix: pin release-v0.8.5 gate to constant version (unblocks all PRs)#923
Conversation
…ry later release) The "docs point at the action patch" test derived `version` from the CHANGELOG's top entry and asserted it equals "0.8.5". After 0.8.6 shipped, the top entry moved to 0.8.6, so the assertion permanently failed — broken on main, blocking every PR (seen on #918, #854). Only the 0.8.5 gate had this pattern. This gate is specific to the 0.8.5 release (docs reference the patched @v0.8.5, not the broken @v0.8.4). Pin to the constant "0.8.5" and assert that changelog entry EXISTS rather than that it is the latest. Docs assertions unchanged (and passing). Closes 922 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR fixes a stale release gate test in the v0.8.5 adversarial test suite. The test previously extracted the top changelog version and compared it to "0.8.5", which fails whenever newer versions ship. It now directly asserts the changelog contains a Changesv0.8.5 Release Gate Stability
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Fixes a stale release-gate test that is broken on
mainand blocks every current PR (observed on #918 and #854).release-v0.8.5-adversarial.test.ts→ "docs point at the action patch…" derived the version from the CHANGELOG's top entry and asserted it equals hardcoded"0.8.5". Once 0.8.6 shipped, the top entry became0.8.6→ the assertion permanently fails (Expected "0.8.5", Received "0.8.6"). Only the 0.8.5 gate has this pattern (0.8.6's does not).The 0.8.5 gate is release-specific (docs must reference the patched
@v0.8.5, not the broken@v0.8.4). Fix: pin to the constant"0.8.5"and assert that changelog entry exists rather than that it is the latest. The docs assertions are unchanged and already pass.Type of change
Issue for this PR
Closes #922
How did you verify your code works?
release-v0.8.5-adversarial.test.tsnow passes (13/13; was failing on the version assertion).main(independent of feature work) and that only the 0.8.5 gate uses the changelog-top pattern.Checklist
Summary by cubic
Pin the v0.8.5 release-gate test to "0.8.5" and assert the changelog entry exists, fixing a failure on main and unblocking all PRs.
## [0.8.5].@v0.8.5(not@v0.8.4).Written for commit c01e0ba. Summary will update on new commits.
Summary by CodeRabbit