fix(hdr): 保留客户端黑位精度 - #95
Conversation
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesHDR 调整
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/sunshine-mock-connection-test.js`:
- Around line 970-974: Update the regression test around defaultBrightnessQuery
to exercise launchApp() and assert the captured
launchRequest.query.minBrightness equals '0.001'. Keep the test configuration’s
minBrightness set to undefined, and remove the assertion that only inspects
buildLaunchQuery() output.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: b09e898c-b518-4eb9-ab1f-63832a453ea2
📒 Files selected for processing (4)
entry/src/main/ets/pages/SettingsPageV2.etsentry/src/main/ets/service/streaming/NvHttp.etsentry/src/main/ets/service/streaming/StreamingSession.etsscripts/sunshine-mock-connection-test.js
问题
鸿蒙的
BrightnessInfo只提供峰值/动态范围,不提供面板最小亮度。客户端此前把未知黑位写成2 nit,手动峰值覆盖还会把它至少取整到1 nit;这些值映射到 Sunshine 虚拟显示器或物理显示器色彩配置后,会人为抬高内容黑位元数据,影响 HLG / HDR Vivid 输出。修改
0.001 nit1 nitminBrightness=0.001验证
npm run checkassembleHar(nativelib,debug)assembleApp(project,debug)git diff --check这次只修黑位元数据和设置说明,没去乱碰解码链路,杂鱼也能放心测啦。
Summary by CodeRabbit