fix(hdr): 应用解码器颜色元数据 - #94
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
Changes解码器元数据初始化
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qiin2333
force-pushed
the
codex/fix-avcodec-color-metadata
branch
from
July 29, 2026 10:37
2291af6 to
a69939e
Compare
qiin2333
marked this pull request as ready for review
July 29, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了啥呀
OH_MD_KEY_VIDEO_IS_HDR_VIVID的解码器 Configure 用法,继续依赖码流内 CUVA 元数据触发 HDR Vivid为啥要改
这些 AVCodec key 在 Harmony SDK 中是导出的
const char*变量,不是预处理宏。原来的#ifdef会把写入逻辑悄悄裁掉——杂鱼预处理判断把真正该工作的 key 挡在门外啦。另外,最新版 OpenHarmony 将
OH_MD_KEY_VIDEO_IS_HDR_VIVID定义为媒体文件轨道标记,仅支持 demuxer/muxer;解码器应从保留的 HEVC/AV1 CUVA 元数据识别 Vivid。影响范围
验证
npm run checknode hvigorw.js assembleHar --mode module -p module=nativelib@default -p product=default -p buildMode=debug --no-daemon --stacktracellvm-nm -D确认产物引用四个颜色 metadata key,且不再引用OH_MD_KEY_VIDEO_IS_HDR_VIVIDgit diff --checkSummary by CodeRabbit