fix(streaming): recover RTSP host resolution - #93
Merged
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了啥呀
sessionUrl0提取 RTSP 主机,兼容 IPv4、带方括号 IPv6 和rtspenc://-2且失败于名称解析阶段时,停止旧连接并用sessionUrl0主机重试一次为啥要这样
日志里 Sunshine 已完成 launch、虚拟显示器与编码器准备,但鸿蒙端在发出 RTSP DESCRIBE 前就以
-2结束;Qt 客户端连接一次后鸿蒙又恢复,符合所选 hostname 在 launch/resume 后解析失效的表现。不能无条件改用
sessionUrl0:公网 IPv4/NAT 场景里它可能是不可达的内网地址。所以只在“名称解析阶段 + -2”这个明确条件下回退,别让修复变成另一只杂鱼 bug 呀。验证
npm run check(仓库检查、许可证检查、11 组 mock 连接测试)assembleApp完整构建成功git diff --checkSummary by CodeRabbit
改进
自检