style(stream-menu): improve readability across system themes - #81
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough新增串流菜单语义颜色资源及统一映射,将游戏菜单各区域迁移到新颜色体系,并把覆盖层标准模糊度从 40 调整为 20。 Changes串流菜单主题与界面样式
Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了啥呀
StreamMenuColors语义资源,通过base/dark资源限定自动跟随系统主题40降到20,并收敛阴影参数,控制额外合成开销为啥要改
原先菜单主要依赖白色半透明文字和卡片,遇到亮白或 HDR 串流内容时对比度会明显下降。组件内手动判断主题还会让颜色逻辑分散,维护起来也很杂鱼。
这次把主题差异留在资源层,组件只消费语义色:既保留马卡龙和玻璃质感,也让系统浅色、深色主题各自拥有稳定可读的前景与表面组合。
验证
npm run checkDEVECO_SDK_HOME=/Applications/DevEco-Studio.app/Contents/sdk node hvigorw.js default@CompileArkTS --mode module -p module=entry@default -p product=default -p buildMode=debug --no-daemonjq empty entry/src/main/resources/base/element/color.jsonjq empty entry/src/main/resources/dark/element/color.jsongit diff --check4.722:1、Dark5.009:1;图形/控件最低 Base3.405:1、Dark3.185:1当前 HDC 无连接设备,尚未完成真机串流画面和菜单打开时系统主题热切换的视觉验收。
Summary by CodeRabbit
新功能
样式