feat(stream): add three-finger IME gesture - #43
Conversation
|
Warning Review limit reached
More reviews will be available in 21 minutes and 28 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough新增三指触摸唤起系统 IME 功能:在 Changes三指 IME 系统手势
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@entry/src/main/ets/pages/StreamPage.ets`:
- Around line 1806-1813: The scheduleThreeFingerImeReset method unconditionally
calls resetThreeFingerImeGesture after 3 seconds, which causes the three-finger
gesture to be cleared prematurely even while the user is still holding down
their fingers. This allows subsequent Move/Up events to be transmitted to the
remote end, triggering unwanted IME behavior. Modify the setTimeout callback in
scheduleThreeFingerImeReset to only call resetThreeFingerImeGesture if there are
no active touch points remaining, effectively converting the 3-second timer into
a watchdog that only resets the gesture when the user has released all their
fingers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 84885dcd-f9e7-49e2-84c4-c12b79490072
📒 Files selected for processing (5)
entry/src/main/ets/components/virtual/VirtualController.etsentry/src/main/ets/pages/StreamPage.etsentry/src/main/ets/service/input/PanZoomHandler.etsentry/src/main/ets/service/input/TouchInputHandler.etsentry/src/main/ets/service/input/TrackpadGestureHandler.ets
改了啥呀
为啥要改
验证
git diff --checkNODE_PATH=/Users/mac/Program/moonlight-harmony/hvigor/node_modules DEVECO_SDK_HOME=/Users/mac/ohos-sdk-cache/6.1-Release-mac/sdk-ci-shape JAVA_HOME=/Users/mac/ohos-sdk-cache/jdk17-temurin/Home PATH=/Users/mac/ohos-sdk-cache/jdk17-temurin/Home/bin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/pkg/env/global/bin:/Library/Apple/usr/bin:/opt/homebrew/bin:/Users/mac/.codex/tmp/arg0/codex-arg0IHuenb:/Users/mac/.bun/bin:/Users/mac/.nvm/versions/node/v20.20.1/bin:/Users/mac/.orbstack/bin:/Applications/Codex.app/Contents/Resources:/Users/mac/.orbstack/bin node hvigorw.js assembleHap --mode module -p module=entry@default -p product=default --no-daemon注:本地构建前按仓库现有流程执行过
bash ci/patch-sdk.sh /Users/mac/ohos-sdk-cache/6.1-Release-mac/sdk-ci-shape来补公共 SDK stubs。Summary by CodeRabbit
发布说明
新功能
改进