Hud screen edit by shvaich · Pull Request #77 · Alexdoru/MWE

shvaich · 2026-07-09T20:14:28Z

made changes to the hud edit screen and the hud button.
also removed 2 icons and added 2 icons

Alexdoru · 2026-07-16T09:24:56Z

I would like to keep the reset and move buttons accessible from the config gui screen

… code

shvaich · 2026-07-16T13:29:45Z

RendererGuiButton UI:

Buttons UI:

Buttons Hover UI:

Dragging UI (invisible buttons):

shvaich · 2026-07-16T13:49:35Z

if you want, I can add another button to the 'renderer edit screen' that when clicked will make all buttons invisible until a key is pressed or something like that

shvaich · 2026-07-19T14:03:53Z

I merged the updated master branch to this. looking back at previous messages you might've done this for me before

Alexdoru · 2026-07-20T12:43:06Z

 import java.lang.reflect.Field;
 import java.lang.reflect.Method;

 public class RendererGuiButton extends ConfigGuiButton {


I disagree with the changes in this class, please roll back your changes and keep the two buttons like it was before

I understand but I very much disagree with this.

I am keeping the Move HUD Button but as shown in the image it is no longer an "Image Button" and its text is Position.
If you like its text can be Move HUD.

There is no reason for the Reset Button to be placed here.
2.1. I am already creating such a button for use inside the Hud Edit Screen.
2.2 It is bad placement. Players cannot see where the hud is once they press this button here, they have to press on the Move HUD aswell to see its new position.

ok can you change the text to something else than "Position", "Move HUD" would be more explicit, also you might need to add a color to the palette for the text color

Alexdoru · 2026-07-20T12:43:29Z

    private final RendererPosition rendererPosition;
    private final GuiScreen parent;
+    private final ColorPalette colorPalette;
+    private final Button[] buttons;


don't make an array but create mutliple fields

Alexdoru · 2026-07-20T12:45:30Z

-        this.rendererPosition.updateAbsolutePosition();
-        this.adjustBounds();
+        final ScaledResolution res = new ScaledResolution(mc);
+        this.rendererPosition.updateAbsolutePosition(res);


mark deprecated the method this.rendererPosition.updateAbsolutePosition(); that is now not used anymore

Alexdoru · 2026-07-20T12:48:48Z


    private GuiUtil() {}

+    public static final int MOUSE_LEFT = 0;


delete this field

This field should be used throughtout the codebase instead of the magic value when comparing with mouseButton.

This is not just for this pull request but for further onces aswell.

ok but I dislike it being here, just make it a local variable in the RendererEditGuiScreen

for the ConfigGuiScreen I can add an MouseClick enum or something to remove the magic numbers

I understand this and I will make it a local variable for now.
but think of it like this, many different classes check mouseButton:
ConfigGuiScreen, RendererEditGuiScreen, ColorEditScreen, ConfigGuiButtons, etc...

and it would be convinient and easy to read if this value was shared.
also for developers who create their own elements.
and there is no need to create an enum for this, this is simple enough and very understandable to me and I assume other devs.
later on you can also add MOUSE_RIGHT = 1 if you want

Alexdoru · 2026-07-20T12:51:11Z


+    private static final class Button extends ClickGuiButton {
+        private final ResourceLocation icon;
+        private final String hoveringText;


add the hovering text feature to the parrent class click gui button directly

I will do this.
I also have an idea to add possible hovering text to ConfigUIElements like in my codebase.
I will show you what I mean in a different pull request but keep it in mind

Alexdoru · 2026-07-20T12:51:23Z

        drawTexturedModalRect(this.width / 2 - 7, this.height / 2 - 7, 0, 0, 16, 16);
    }

+    private static final class Button extends ClickGuiButton {


create a standalone class named TexturedButton that draws the icon

Alexdoru · 2026-07-20T12:53:46Z

+                        if (clickedButtonIdx == 0) rendererPosition.resetToDefault();
+                        else if (clickedButtonIdx == 1) rendererPosition.setRelativePosition(originalRelativeX, originalRelativeY);
+                        else break success;
+                        final ScaledResolution res = new ScaledResolution(mc);


save the scaled resolution as a field that is initializd in initGui

Alexdoru · 2026-07-20T12:57:23Z

    private int prevX, prevY;

-    public RendererEditGuiScreen(RendererManager rendererManager, IRenderer renderer, GuiScreen parent) {
+    public RendererEditGuiScreen(RendererManager rendererManager, IRenderer renderer, GuiScreen parent, ColorPalette colorPalette) {


don't need to add ColorPalette as a parameter just change the type of the parent parameter to ConfigGuiScreen

Alexdoru · 2026-07-20T12:59:16Z

+                    }
+                }
+                if (clickedButtonIdx != -1) {
+                    success: {


you shouldn't use labels and break and also this is bugged because if clickedButtonIdx is not 0 or not 1 it will loop infinitely

you are mistaken, this is not how either works.
the loop I have is itterating over the buttons array, it only breaks early if I find a clicked button because i can only click on one button.

now the label after it is just for simplicity, because if clickedButtonIdx is either 0 or 1 I am updating the relative position and then need to update the absolute position, so what I am doing is updating the relative position, (see if (clickedButtonIdx == 0) and else if (clickedButtonIdx == 1))
and then updating the absolute position and returning from the function to not trigger isDragging.
(see code after else break success)

if clickedButtonIdx isn't 0 or 1 it will simply break from the success block and move on to isDragging logic. (see else break success)

There is nothing in this code that can cause an infinite loop and the only reason its written this way is because if I do decide to add more buttons I can write the logic easily at the end of the success block

if clickbutton == 2 it will loop indefinitely, also I have never seen labels and breaks outside of loop for a good reason you should not use them outside of loops plase change your code

I understand your reason for not wanting to use labels so I wont. but you are mistaken in your image.
what happens when you break from a labeled-block is that you go to the end of the block.
what would actually happen in my code if clickButton == 2 is that the code will continue from }.
example:

int clickButton = 2; success: { if (clickButton == 0) {} else if (clickButton == 1) {} else break success; log("0 or 1!"); return } log("not 0 or 1!");

if clickButton is 2, it will log: not 0 or 1!.
if clickButton is 0 or 1 it will log: 0 or 1!

shvaich

Agreed with some.
To what I didnt agree I commented.
Whatever you decide on after reading my replays i will do

shvaich · 2026-07-20T13:38:20Z

+                    }
+                }
+                if (clickedButtonIdx != -1) {
+                    success: {


you are mistaken, this is not how either works.
the loop I have is itterating over the buttons array, it only breaks early if I find a clicked button because i can only click on one button.

now the label after it is just for simplicity, because if clickedButtonIdx is either 0 or 1 I am updating the relative position and then need to update the absolute position, so what I am doing is updating the relative position, (see if (clickedButtonIdx == 0) and else if (clickedButtonIdx == 1))
and then updating the absolute position and returning from the function to not trigger isDragging.
(see code after else break success)

if clickedButtonIdx isn't 0 or 1 it will simply break from the success block and move on to isDragging logic. (see else break success)

There is nothing in this code that can cause an infinite loop and the only reason its written this way is because if I do decide to add more buttons I can write the logic easily at the end of the success block

shvaich · 2026-07-20T13:41:23Z


    private GuiUtil() {}

+    public static final int MOUSE_LEFT = 0;


This field should be used throughtout the codebase instead of the magic value when comparing with mouseButton.

This is not just for this pull request but for further onces aswell.

shvaich · 2026-07-20T13:47:54Z

 import java.lang.reflect.Field;
 import java.lang.reflect.Method;

 public class RendererGuiButton extends ConfigGuiButton {


I understand but I very much disagree with this.

I am keeping the Move HUD Button but as shown in the image it is no longer an "Image Button" and its text is Position.
If you like its text can be Move HUD.

There is no reason for the Reset Button to be placed here.
2.1. I am already creating such a button for use inside the Hud Edit Screen.
2.2 It is bad placement. Players cannot see where the hud is once they press this button here, they have to press on the Move HUD aswell to see its new position.

shvaich · 2026-07-20T13:50:53Z


+    private static final class Button extends ClickGuiButton {
+        private final ResourceLocation icon;
+        private final String hoveringText;


I will do this.
I also have an idea to add possible hovering text to ConfigUIElements like in my codebase.
I will show you what I mean in a different pull request but keep it in mind

shvaich added 7 commits July 9, 2026 22:26

added custombutton class

0b58770

re-order of logic, updating cords should come before drawing

0144398

removed 'reset' button and icons. edited 'move hud' button

ea93020

added a helper method to render a full texture

5fc9907

added 'reset' button and 'undo' button

00a9d1d

added 'reload' and 'undo' icons. removed 'reset' and 'move' icons

5d85d9a

removed unused imports

cf9d466

shvaich added 3 commits July 16, 2026 16:19

added public method to get the color palatte

adfee8b

send the config screen color palette to renderer edit screen

a864571

changed the way i create 'custom buttons' and fixed bad buttons click…

4b40416

… code

shvaich force-pushed the hud_screen_edit branch from f249d6b to 4b40416 Compare July 16, 2026 13:25

shvaich and others added 4 commits July 18, 2026 20:54

Merge branch 'master' into hud_screen_edit

110424b

removed unnecessary comment trimming

9b2da5c

Merge branch 'master' into hud_screen_edit

0ab7459

Merge branch 'Alexdoru:master' into hud_screen_edit

6b59230

Alexdoru requested changes Jul 20, 2026

View reviewed changes

shvaich commented Jul 20, 2026

View reviewed changes

Conversation

shvaich commented Jul 9, 2026

Uh oh!

Alexdoru commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shvaich commented Jul 16, 2026

Uh oh!

shvaich commented Jul 16, 2026

Uh oh!

shvaich commented Jul 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shvaich Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shvaich Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shvaich left a comment

Choose a reason for hiding this comment

Uh oh!

shvaich Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shvaich Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Alexdoru commented Jul 16, 2026 •

edited

Loading

shvaich Jul 20, 2026 •

edited

Loading

shvaich Jul 20, 2026 •

edited

Loading

shvaich Jul 20, 2026 •

edited

Loading

shvaich Jul 20, 2026 •

edited

Loading