🎨 Palette: Actionable Escape-to-Clear Shortcut#592
Conversation
Co-authored-by: AhmmedSamier <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe search webview now clears non-empty queries and resets scopes when ChangesSearch clearing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bfd7655c07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| searchInput.addEventListener('keydown', (e) => { | ||
| if (e.key === 'ArrowDown') { | ||
| if (e.key === 'Escape' && searchInput.value !== '') { |
There was a problem hiding this comment.
Reset filters even when the query is empty
When a scope is active with no remaining text (for example, clicking the Modified/Open scope on an empty input or entering /m , which gets stripped to an empty value), searchInput.value is '', so this Escape handler falls through and leaves currentScope, userScope, and the active scope button unchanged. That makes the new shortcut unable to recover from a filtered-empty state; please treat a non-default scope as something Escape should clear while still passing through only when the input is already empty and the scope is already global.
Useful? React with 👍 / 👎.
Co-authored-by: AhmmedSamier <[email protected]>
💡 What: Added an
Escapekey handler to the search input in the search webview that clears the input text and resets all active scopes and filters back to their global defaults.🎯 Why: Users intuitively expect the
Escapekey to clear a search input and reset the search context, especially when multiple filters are active. Lacking this native behavior adds friction.📸 Before/After: Before, pressing
Escapewhile focused on the search input did nothing. Now, pressingEscapeclears the input, resets the search scope to 'Everything', and focuses the input. If the input is already empty, the event passes through.♿ Accessibility: Improves keyboard navigation by providing a standard, universally recognized shortcut to quickly recover from a filtered or typed state without relying on mouse clicks or manual text deletion.
PR created automatically by Jules for task 5289999865392006588 started by @AhmmedSamier
Summary by CodeRabbit