🔒 Fix Missing Validation for Notification Content in sendNotification - #18
🔒 Fix Missing Validation for Notification Content in sendNotification#18Salint wants to merge 1 commit into
Conversation
Adds server-side validation to the sendNotification Cloud Function. It ensures that the `message` payload parameter is a non-empty string and does not exceed a length limit of 1024 characters. This prevents malformed requests and overly large payloads that could lead to DoS or unnecessary costs. Co-authored-by: Salint <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The
⚠️ Risk: An attacker could send malformed data or arbitrarily large payloads via the
messagepayload in thesendNotificationCloud Function lacked validation for its type, content, and length.messageparameter. If left unfixed, this could lead to unintended push notification behaviors, instability, potential denial of service (DoS), or increased costs.🛡️ Solution: Added robust validation checks ensuring the
messageparameter is a non-empty string and capped at 1024 characters. Malformed requests will now be rejected with a standardHttpsError("invalid-argument").PR created automatically by Jules for task 14401194137918346460 started by @Salint