Skip to content

🔒 Secure Firestore Rules for Statuses - #17

Open
Salint wants to merge 1 commit into
mainfrom
fix-insecure-firestore-statuses-rules-2550379534735389613
Open

🔒 Secure Firestore Rules for Statuses#17
Salint wants to merge 1 commit into
mainfrom
fix-insecure-firestore-statuses-rules-2550379534735389613

Conversation

@Salint

@Salint Salint commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

🎯 What: The vulnerability fixed

This PR addresses insecure Firestore rules for the statuses collection where any authenticated user could create, update, or delete any status document.

⚠️ Risk: The potential impact if left unfixed

Without these changes, a malicious authenticated user could:

  1. Create status documents on behalf of other users (spoofing).
  2. Modify existing statuses of other users.
  3. Delete statuses belonging to other users.

🛡️ Solution: How the fix addresses the vulnerability

  1. Firestore Rules: Updated firestore.rules to ensure that for create, update, and delete operations, the userId field in the document matches the uid of the authenticated user.
  2. Cloud Function: Since direct updates are now restricted to owners, a new viewStatus Cloud Function was added to safely allow other users to mark a status as viewed by appending their UID to the viewedBy array.
  3. App Integration: Updated the StatusRepository to use the new Cloud Function for marking statuses as viewed, ensuring no loss of functionality while maintaining security.

PR created automatically by Jules for task 2550379534735389613 started by @Salint

…unction

- Update `firestore.rules` to restrict create, update, and delete operations on the `statuses` collection to the document owner.
- Implement a new `viewStatus` Cloud Function to securely allow users to mark status items as viewed by adding their UID to the `viewedBy` array.
- Update `StatusRepository` in the Flutter app to call the `viewStatus` Cloud Function instead of performing direct Firestore updates.
- Export the new `viewStatus` function in `functions/index.js`.

Co-authored-by: Salint <[email protected]>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant