-
Notifications
You must be signed in to change notification settings - Fork 0
feat(persona-kit): suppress codex 'are you sure?' via single bypass flag #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c7e74b0
9fb0eab
a86e842
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Warning message for opencode omit newly added Same issue as the claude branch: the opencode warning at line 303 lists the four original codex-only settings but not the newly added (Refers to line 303) Was this helpful? React with 👍 or 👎 to provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Warning messages for claude/opencode omit newly added
dangerouslyBypassApprovalsAndSandboxsettingThe
hasCodexLaunchSettings()function atpackages/persona-kit/src/interactive-spec.ts:83-92now detectsdangerouslyBypassApprovalsAndSandbox, but the warning messages emitted by the claude (line 233) and opencode (line 303) branches still enumerate only the original four settings:sandboxMode, approvalPolicy, workspaceWriteNetworkAccess, and webSearch. If a persona sets onlydangerouslyBypassApprovalsAndSandbox: truewith a non-codex harness, the trigger fires but the warning names settings the user never set, making it confusing rather than helpful.(Refers to line 233)
Was this helpful? React with 👍 or 👎 to provide feedback.