[DT-15] issue resolved - #20
Conversation
created a class??? similar to what i was asked created a script which is how i would do it (and it is without class)
|
Think the code overall looks fine, though I haven't tested the script or checked it against the CSV format. In terms of use of OOP we need to be clearer with what the intention is (which admittedly isn't set in stone yet...) Probably the main thing I'd like is to allow for input of a dataframe with some fixed schema (rather than read in a CSV and process the data), but such a level of abstraction might not be necessary at this juncture. Based on our discussions on Streamlit, we can first look into taking data from the SQL database and then adapt the script here to perform the required postprocessing. |
|
Converted to draft since we'd be working on this more. I would suggest testing functionality of Streamlit by getting it to do the postprocessing we perform in this script. |
|
i think just keep my branch up to date with the main branch |
2 participants
created a class??? similar to what i was asked
created a script which is how i would do it (and it is without class)