Refine pragma flare RFC#233
Open
viljar-indus wants to merge 1 commit into
Open
Conversation
viljar-indus
force-pushed
the
topic/rfc-flare-refine
branch
from
1ea5389 to
ba464d8
Compare
tonunaks
reviewed
Jul 9, 2026
tonunaks
reviewed
Jul 9, 2026
tonunaks
reviewed
Jul 9, 2026
tonunaks
reviewed
Jul 9, 2026
tonunaks
reviewed
Jul 9, 2026
tonunaks
reviewed
Jul 9, 2026
tonunaks
reviewed
Jul 9, 2026
tonunaks
left a comment
tonunaks
left a comment
Collaborator
There was a problem hiding this comment.
I added some grammar-oriented nits, and a few recommendations to make the text clearer.
Looks good, overall!
viljar-indus
force-pushed
the
topic/rfc-flare-refine
branch
from
ba464d8 to
387ca52
Compare
viljar-indus
commented
Jul 10, 2026
viljar-indus
left a comment
viljar-indus
left a comment
Contributor
Author
There was a problem hiding this comment.
Thank you for your comments.
viljar-indus
force-pushed
the
topic/rfc-flare-refine
branch
from
387ca52 to
54f832f
Compare
tonunaks
reviewed
Jul 14, 2026
tonunaks
reviewed
Jul 14, 2026
viljar-indus
force-pushed
the
topic/rfc-flare-refine
branch
from
54f832f to
d66ee2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more explicit examples and refine the use of pragma flare