Amanda & Stacy D. - #62
Open
amandajones1996 wants to merge 12 commits into
Open
Conversation
ameerrah9
reviewed
Jun 27, 2023
Comment on lines
+13
to
+29
| <h1 class="header" id = "header_id1"> Today's Weather Report </h1> | ||
| <h3 class="header" id = "header_id2"> For The Lovely City of <span id = "header-city">Atlanta</span></h3> | ||
| <h4 id="temp">Temperature</h4> | ||
| <button id="up">⬆</button> | ||
| <p id="temperature-now"></p> | ||
| <button id="down">⬇</button> | ||
| <button id="real-time-temp">Get Real Time Temperature</button> | ||
| <form id="cityinput"> | ||
| City: | ||
| <input id ="city" type="text" placeholder="Enter a city"/> | ||
| </form> | ||
| <button id="defaultCity">Reset</button> | ||
| <h4 id="garden"></h4> | ||
| <!-- <span </span id="sky"></span> --> | ||
| <span </span id="weather-garden"></span> | ||
| <h4 id="sky"></h4> | ||
| <select id="sky-drop-down"> |
ameerrah9
reviewed
Jun 27, 2023
Comment on lines
+30
to
+35
| <option value="Sunny">Choose Your Sky</option> | ||
| <option value="Sunny">Sunny</option> | ||
| <option value="Cloudy">Cloudy</option> | ||
| <option value="Snowy">Snowy</option> | ||
| <option value="Rainey">Rainy</option> | ||
| </select> |
ameerrah9
reviewed
Jun 27, 2023
Comment on lines
+2
to
+14
| const state = { | ||
| temperature: 1, | ||
| upButton: null, | ||
| downButton: null, | ||
| tempDisplay: 10, | ||
| city: null, | ||
| headerCity: null, | ||
| weatherGarden: null, | ||
| skyDropDown: null, | ||
| sky: null, | ||
| defaultCity: null, | ||
| realTimeTemp : null | ||
| }; |
ameerrah9
reviewed
Jun 27, 2023
Comment on lines
+82
to
+89
| const accessLocation = () => { | ||
| axios.get(`http://127.0.0.1:5000/location?q=${state.headerCity.textContent}`).then(resp => { | ||
| let lat = resp.data[0]["lat"] | ||
| let lon = resp.data[0]["lon"] | ||
| accessWeather(lat, lon); | ||
| }) | ||
| .catch(error => console.log(error)) | ||
| }; |
There was a problem hiding this comment.
Great function naming, this looks really clean 💯
ameerrah9
reviewed
Jun 27, 2023
| console.log(resp.data["main"]["temp"]) | ||
| state.temperature = kelvinToFarenheit(resp.data["main"]["temp"]) | ||
| state.tempDisplay.innerText = state.temperature | ||
| changeTemp(); |
ameerrah9
reviewed
Jun 27, 2023
Comment on lines
+105
to
+127
| const changeTemp = () => { | ||
| if (state.temperature >= 80) { | ||
| state.tempDisplay.style.color = "rgb(252, 115 , 115)"; | ||
| state.weatherGarden.textContent = "🌵__🐍_🦂_🌵🌵__🐍_🏜_🦂"; | ||
| document.body.style.backgroundColor = "rgb(255, 194 , 185)" | ||
| } else if (state.temperature >= 70) { | ||
| state.tempDisplay.style.color = "rgb(229, 114, 0)"; | ||
| state.weatherGarden.textContent = "🌸🌿🌼__🌷🌻🌿_☘️🌱_🌻🌷"; | ||
| document.body.style.backgroundColor = "rgb(252, 179 , 137)" | ||
| } else if (state.temperature >= 60) { | ||
| state.tempDisplay.style.color = "rgb(255, 217, 0)"; | ||
| state.weatherGarden.textContent = "🌾🌾_🍃_🪨__🛤_🌾🌾🌾_🍃"; | ||
| document.body.style.backgroundColor = "rgb(255, 253, 179)" | ||
| } else if (state.temperature >= 50) { | ||
| state.tempDisplay.style.color = "green"; | ||
| state.weatherGarden.textContent = "🌲🌲⛄️🌲⛄️🍂🌲🍁🌲🌲⛄️🍂🌲"; | ||
| document.body.style.backgroundColor = "rgb(204, 250, 192)" | ||
| } else { | ||
| state.tempDisplay.style.color = "teal"; | ||
| state.weatherGarden.textContent = "🌲🌲⛄️🌲⛄️🍂🌲🍁🌲🌲⛄️🍂🌲"; | ||
| document.body.style.backgroundColor = "rgb(192, 246, 250)" | ||
| } | ||
| }; |
There was a problem hiding this comment.
Your conditional comprehension is very strong
ameerrah9
reviewed
Jun 27, 2023
Comment on lines
+2
to
+24
| body{ | ||
| display: grid; | ||
| height: 100vh; | ||
| width: 100vw; | ||
| grid-template: 12.5% 12.5% 9.375% 9.375% 9.375% 9.375% 9.375% 9.375% 9.375% 9.375% / 20% 20% 20% 20% 20%; | ||
| /* border-radius: 100px; */ | ||
| border-style: solid; | ||
| padding: 10px; | ||
| border: 10px; | ||
| border-width: 10px; | ||
| border-color: black; | ||
| } | ||
|
|
||
| #defaultCity { | ||
| grid-row-start: 9; | ||
| grid-row-end: 10; | ||
| color: black; | ||
| background-color: lightpink; | ||
| } | ||
|
|
||
| #cityinput { | ||
| grid-row-start: 8; | ||
| grid-row-end: 9; |
ameerrah9
reviewed
Jun 27, 2023
ameerrah9
left a comment
ameerrah9
left a comment
There was a problem hiding this comment.
Great work, Amanda + Stacy! 🥳
Thank you for your patience as we catch up on grading. Nice work! The HTML is structured well and the JS is clear and well-factored. This project is a Green. 🟢
Keep it up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.