Earth/Taylor - #42
Open
TaylorMililani wants to merge 20 commits into
Open
Conversation
CheezItMan
reviewed
Nov 20, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Media Ranker
Functional Requirements: Manual Testing
| Criteria | yes/no |
|---|---|
| Before logging in | -- |
| 1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight | ✔️ |
| 2. Can go into a work's show page | ✔️ |
| 3. Verify unable to vote on a work, and get a flash message | ✔️, it makes me login, 💯 |
| 4. Can edit this work successfully, and get a flash message | ✔️ |
| 5. Can go to "View all media" page and see three lists of works, sorted by vote | |
| 6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message | |
| 7. Can create a new work successfully. Note the URL for this work's show page | ✔️ |
| 8. Can delete this work successfully | ✔️ |
| 9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view) | ✔️ |
| 10. Verify that the "View all users" page lists no users | ✔️ |
| Log in | -- |
| 11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons | ✔️ |
| 12. Your username is listed in "View all users" page | ✔️ |
| 13. Verify that number of votes determines the Media Spotlight | ✔️ |
| 14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page | |
| 15. Voting on the same work twice produces an error and flash message, and there is no extra vote | ✔️ |
| Log out | -- |
| 16. Logging out showed a flash message and changed the UI | ✔️ |
| 17. Logging in as a new user creates a new user | ✔️ |
| 18. Logging in as an already existing user has a specific flash message | ✔️ |
Major Learning Goals/Code Review
| Criteria | yes/no |
|---|---|
| 1. Sees the full development cycle including deployment, and the app is deployed to Heroku | ✔️ |
| 2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker | ✔️, close'nuf |
| 3. Practices git with at least 25 small commits and meaningful commit messages | ✔️ Not enough small granular commits |
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
| Criteria | yes/no |
|---|---|
4. Routes file uses resources for works |
✔️ |
| 5. Routes file shows intention in limiting routes for voting, log-in functionality, and users | ✔️, just one extra custom route |
| 6. The homepage view, all media view, and new works view use semantic HTML | |
| 7. The homepage view, all media view, and new works view use partials when appropriate | |
8. The model for media (likely named work.rb) has_many votes |
✔️ |
| 9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category | ✔️ |
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user |
✔️ |
11. Some controller, likely the WorksController, has a controller filter for finding a work |
|
12. The WorksController uses strong params |
✔️ |
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash |
✔️, for the most part, see my comments |
Testing Rails Apps
| Criteria | yes/no |
|---|---|
| 14. There are valid fixtures files used for users, votes, and works | |
| 15. User model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️ |
| 16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote) | ✔️ |
| 17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️ |
| 18. Work model has tests with a section on all business logic methods in the model, including their edge cases |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 14+ in Functional Requirements: Manual Testing && 14+ in Code Review | 💚 |
Code Style Bonus Awards
Was the code particularly impressive in code style for any of these reasons (or more...?)
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Elegant/Clever | ✅ |
| Descriptive/Readable | ✅ |
| Concise | ✅ |
| Logical/Organized | ✅ |
Summary
1st off I do want to apologize, it's midnight, and I'm a little tired and punchy at this point. I may have left some tongue-in-cheek feedback. Please chalk that up to sleep deprivation. Let me know if it's out of line.
This is a good submission, you hit the main learning goals. I like your model methods and you did a good job with routes.rb and controller filters, you even had authorization.
Areas for Improvement:
- Catching edge-cases in tests (very common)
- Using partial views more aggressively
- Using Postgres to do filtering and sorting where you can with
.orderetc. - Styling 🤡
That said this is a very solid submission.
Comment on lines
+4
to
+6
| resources :works do | ||
| resources :votes, only: [:create] | ||
| end |
| resources :works do | ||
| resources :votes, only: [:create] | ||
| end | ||
| get '/works/homepage', to: 'works#homepage', as: 'homepage' |
There was a problem hiding this comment.
This is unnecessary
Suggested change
| get '/works/homepage', to: 'works#homepage', as: 'homepage' |
| post "/logout", to: "users#logout", as: "logout" | ||
| get "/users/current", to: "users#current", as: "current_user" | ||
|
|
||
| post "/works/:id/vote", to: "votes#create", as: "vote" |
There was a problem hiding this comment.
You have the nested route, do you need this?
| it "wont allow a new user to be created without a username" do | ||
| new_user.username = nil | ||
|
|
||
| expect(new_user.valid?).must_equal false |
There was a problem hiding this comment.
Also test the validation error message.
| it "wont create a vote if a user has already voted for that work" do | ||
| @vote = Vote.create(work_id: @work2[:id],user_id: @user[:id]) | ||
|
|
||
| expect(@vote.valid?).must_equal false |
There was a problem hiding this comment.
Also test the validation error message.
| end | ||
|
|
||
| def show | ||
| @work = Work.find_by(id: params[:id]) |
There was a problem hiding this comment.
Did you know you can do this line as a filter just like the require login?
| redirect_to work_path(id: @work[:id]) | ||
| return | ||
| else | ||
| flash.now[:error] = "Hmm..something went wrong, your work was not saved" |
There was a problem hiding this comment.
It's better to show the validation errors so they know precisely what's wrong.
Comment on lines
+55
to
+57
| @work.update(work_params) | ||
| flash[:success] = "You've successfully edited this work!" | ||
| redirect_to work_path(id: @work[:id]) |
There was a problem hiding this comment.
What if the update fails?
You should have an if to check and show validation errors.
Comment on lines
+9
to
+11
| def self.category_filter(category) | ||
| return self.where(category: category) | ||
| end |
| @works = Work.all | ||
| category_works = @works.category_filter(category) | ||
|
|
||
| sorted = category_works.sort_by { |work| work.votes.count }.reverse |
There was a problem hiding this comment.
Minor knitpick:
It's best to let Postgres (the database) do the sorting and filtering if you can. You can use .order and .limit to tell Postgres how to sort and filter, even on an associated model.
Your code works fine, but if the database was huge going through Postgres would be a LOT more efficient.
You can read about it here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?