Skip to content

Feature/general improvements#50

Merged
maldwg merged 8 commits into
feature/domainator-integrationfrom
feature/general-improvements
Jun 29, 2026
Merged

Feature/general improvements#50
maldwg merged 8 commits into
feature/domainator-integrationfrom
feature/general-improvements

Conversation

@maldwg

@maldwg maldwg commented Jun 23, 2026

Copy link
Copy Markdown
Member

No description provided.

@maldwg maldwg requested a review from dreamingdust June 23, 2026 06:30
@maldwg

maldwg commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

Reworked some aspects of hamstring to be more expressive and flexible. Also fixed scaling issues for multithreading/processing.
@dreamingdust can you review the parts I changed in the domainator integration ? I had to rename for instance the feature names as they appeared to be different in new model versions and restructured the detection process for the attribution models a bit. I hope (but I dont think) that I didn't mess up anything. So if you spot a logical error, please let me know :)

dreamingdust
dreamingdust reviewed Jun 29, 2026
View reviewed changes
Comment thread tests/detector/test_domainator_attributor.py Outdated
# Verify prediction result
np.testing.assert_array_equal(result, mock_prediction)

def test_predict_aligns_features_to_model_order(self):

@dreamingdust dreamingdust Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test currently fails. Was the assertEqual perhaps meant to compare with list(DOMAINATOR_FEATURE_COLUMNS) instead of the reversed list?

@dreamingdust dreamingdust Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same test also fails in test_domainator_detector.py

@maldwg maldwg Jun 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! If I am not mistaken it failed because I did not adjust the names for the features in the test cases, after adapting them in the main source scripts. It should be fixed with the last commit :)

@maldwg maldwg merged commit 093d1ef into feature/domainator-integration Jun 29, 2026
@maldwg maldwg deleted the feature/general-improvements branch June 29, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreamingdust dreamingdust dreamingdust left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maldwg @dreamingdust