Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 84.53% 86.59% +2.06%
==========================================
Files 82 105 +23
Lines 5637 6700 +1063
Branches 783 895 +112
==========================================
+ Hits 4765 5802 +1037
- Misses 614 615 +1
- Partials 258 283 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RBhupi
requested review from
sgupta92 and
zssherman
and removed request for
sgupta92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR tags (required)
Select all that apply.
What changed
2-4 bullets in plain language.
Replaced the third-party library with a native adapt/downloaders/ package: an anonymous (unsigned) S3 client, paginated list_objects_v2, and size-verified atomic downloads (.part → verify → os.replace).
NexradS3 is a drop-in backend for the acquisition source (get_avail_scans_in_range / get_avail_radars / download); modules/acquisition only swaps its conn, otherwise unchanged.
Removed nexradaws from pyproject.toml, requirements.txt, environment.yml and added boto3; isolated boto3 to downloaders/ via the heavy-dep fitness test and a new downloaders_are_leaf import-linter contract.
Added offline unit tests mirroring the nexradaws spec, plus a live-AWS parity test (KTLX 2013-05-20 18–22 → 53 scans, real verified download).
Why
1-2 lines on the user/problem impact.
Drops an external dependency we don't control, adds the download verification nexradaws lacked, and concentrates all S3 I/O in one reusable leaf so future datasets (GOES/GLM/MRMS) reuse s3.py unchanged.
Issues closed
List issue references this PR closes
Closes #20 #63
None.
Target version (required)
Aiming for: next patch (current dev line v0.1.3.x)
Validation
Mark each item as done or N/A. Add one short evidence line for each item.
I ran ruff
Evidence (command + pass/fail): ruff check src tests → All checks passed
N/A reason (if not run):
I ran import-linter
Evidence (command + pass/fail): lint-imports → 8 contracts kept, 0 broken (incl. new downloaders_are_leaf)
N/A reason (if not run):
I ran tests
Evidence (command + pass/fail): pytest -m "not integration" → 1095 passed, 2 skipped; pytest -m integration tests/integration/test_nexrad_downloader_integration.py → 2 passed (53-scan parity + real download)
N/A reason (if not run):
AI usage & manual verification
If AI tools were used, complete this section.
AI used: yes
Model/tooling: Claude (Claude Code, Opus 4.x)
Tasks delegated to AI: S3-layout research, implementing the downloaders/ package and tests removing the dependency, and updating the create-adapt-module skill docs.
Manual verification performed: live adapt run-nexrad --radar KGSP realtime run downloaded and processed real scans end-to-end; confirmed Adapt imports/runs with nexradaws made unimportable; reviewed the full diff.