Usecase: postChangeStatusCooking を実装 - #213
Open
woodnx wants to merge 2 commits into
Open
Conversation
hikuohiku
reviewed
Sep 25, 2025
hikuohiku
left a comment
hikuohiku
left a comment
Collaborator
There was a problem hiding this comment.
細かいところ以外は良さそうです、こちらもrouterとの繋ぎ込みお願いします🙏
Collaborator
There was a problem hiding this comment.
フォーマット効いてなさそうです（最終行に改行が入ってないので）
Collaborator
There was a problem hiding this comment.
また名前の話ですが、HTTPリクエストと1対1対応しないといけないわけではないので無理にpostをつけなくても良さそうです
makeDonCookingとかmakeDonStatusCookingがわかりやすそう
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
テストケースも実装