003 feature nearest neighbour sampler#20
Merged
Conversation
oj-tooth
reviewed
Jun 29, 2026
oj-tooth
reviewed
Jun 29, 2026
oj-tooth
reviewed
Jun 29, 2026
oj-tooth
left a comment
oj-tooth
left a comment
Contributor
There was a problem hiding this comment.
Nice work here! Two comments:
-
Should we use xarray internal geographical indexing to identify model grid points by longitude and latitude? Shailee is also doing this, so seems like we could be more closely aligned here.
-
Suggestion on testing - using fixtures for synthetic testing data structures.
…stent rounding results
…he centre (because of inconsistent results)
…ng the geoball output to match.
Collaborator
Author
|
I've added in the time of the profile here now too. So this fixes #7 . |
oj-tooth
approved these changes
Jul 3, 2026
oj-tooth
left a comment
oj-tooth
left a comment
Contributor
There was a problem hiding this comment.
- Nice work, let's get this merged into main and we can always iron out any performance challenges once we get to the first integration test: upper 2000m slab replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #3 . I've started off 1-feature-initial-oceanosse-workflow-skeleton so should be merged after. This branch bring in a sampler that simply finds the nearest neighbour on the model grid to a profile location. There are test to accompany it. At the moment it expects the model dataset to have lat and lon variables, i and j coordinates. It expects the profile dataset to have profile_id as a coordinate.
Fixed a profile which is tied for finding the nearest neighbour gives inconsistent test results.