ci(gfx11): bundle liborigami + add ldd-closure backstop and packaging gate#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release b20260724 shipped broken:
llama-serverexits 127 andllama-benchemits no JSON, both witherror while loading shared libraries: liborigami.so.1: cannot open shared object file.Root cause: the "Copy ROCm core libs" step is a hand-maintained
cp -vallowlist (its own comment warns "If artifacts from ROCm or Llama.cpp change, you may need to update this list."). The b20260724 build bumped ROCm 7.14 -> 7.15, and 7.15'slibhipblaslt.so.1gained a newDT_NEEDEDonliborigami.so.1(a new hipBLASLt kernel-selection lib). Nobody added acpline for it, so it was omitted from the tarball. Every binary hasRUNPATH=$ORIGIN, solibhipblaslt.so.1loads from the release dir but then fails to resolve its ownliborigami.so.1dep.Why CI didn't catch it: the only post-build smoke test runs
llama-cli, which links hipBLASLt lazily and loads fine.llama-bench/llama-serverload hipBLASLt eagerly and break. (Confirmed vialddon the actual b20260724 binaries.)Changes
cp -v /opt/rocm/lib/liborigami.so*to the allowlist next tolibhipblaslt.lddevery bundled binary, and for any=> not founddep that exists under/opt/rocm/lib{,/rocm_sysdeps/lib,/llvm/lib}, copy it in; repeat until closed. The next ROCm bump that adds a newNEEDEDlib is auto-bundled instead of silently shipping broken.ldds every binary and fails the build if anything is unresolved. Runs unconditionally and gatescreate-release. (Note: the GPUtest-gfxjob is currentlyif: falsewhile the runner is offline, so this build-job gate is the real protection.)llama-benchload check totest-gfxso the eager-hipBLASLt path is exercised once the GPU runner returns.Test plan
liborigami.so.1and exits 1).liborigami.so.1from/opt/rocm/libintobuild/binon the 7.15 toolchain.ldd llama-benchandldd llama-servershow nonot founddeps.test-gfx(when runner online) passes both thellama-cliand newllama-benchchecks.