ci: bump base image/runner to v26.4 and drop v26.3-only workarounds#896
Open
WangLingxun wants to merge 4 commits into
Open
ci: bump base image/runner to v26.4 and drop v26.3-only workarounds#896WangLingxun wants to merge 4 commits into
WangLingxun wants to merge 4 commits into
Conversation
WangLingxun
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
July 21, 2026 05:57
WangLingxun
marked this pull request as draft
July 21, 2026 06:21
- ci.yaml: BASE_IMAGE + runs-on v26.3 -> v26.4; drop the v26.3-only 'Purge stale TorchTitan' step (v26.4 ships no torchtitan to shadow). Keep 'Install fixed origami' (v26.4 still ships no origami). - Dockerfile: default BASE_IMAGE + comments v26.3 -> v26.4. - docs/scripts: bump default image refs to v26.4, release branch to release/v26.4, and pip pin to primus==26.4.0.
WangLingxun
force-pushed
the
chore/ci-bump-primus-v26.4
branch
2 times, most recently
from
July 21, 2026 09:24
a6e9036 to
90e0389
Compare
- Dockerfile/ci.yaml: drop the origami install; base image ships none, so primus_turbo falls back to heuristic MoE grouped-gemm kernel selection. - aiter_deepbind_patches.py: skip the RTLD_DEEPBIND hook once transformer_engine >= 2.14 (fixed in rocm/primus:v26.4); still applies on older images. - Add unit tests for the new gating logic.
Container reuse compared only the image tag string, not content. On main, IMAGE_TAG is always "latest", so after build-docker repushes under that tag, the check still saw an identical string and reused the stale container instead of pulling the new image. Fix: pull first, then compare docker image inspect .Id (target) against the container's docker inspect .Image (actual) instead of the tag name.
WangLingxun
force-pushed
the
chore/ci-bump-primus-v26.4
branch
from
July 23, 2026 10:49
62f555d to
11e1885
Compare
WangLingxun
marked this pull request as ready for review
July 23, 2026 10:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the Primus runtime image from
rocm/primus:v26.3tov26.4across CI Dockerfile/workflow, example launch scripts, benchmark scripts and docs, drop v26.3-only CI workarounds now that they're no longer needed, and fix a stale-container bug found while verifying the CI change. JAX/MaxText base image not upgraded this round.Image bump
.github/workflows/ci.yaml&docker/Dockerfile:BASE_IMAGE-> v26.4, sync v26.3 commentsrelease/v26.4, pip pin toprimus==26.4.0runs-onstays on thev26.3self-hosted runner label (nov26.4runner registered yet)Workaround cleanup
rocm-libraries@223648a) install from Dockerfile and CI: this base image ships no origami, soprimus_turbofalls back to heuristic kernel selection for MoE grouped-gemm. Left the pip install one-liner in a comment to add it back if ever needed.aiter_deepbind_patches.pyself-detects whether the RTLD_DEEPBIND workaround is still needed: skips installing it oncetransformer_engine.__version__ >= 2.14(fixed in v26.4), still applies on v26.3 and older. Added unit tests for the gating logic.CI fix
docker.io/tasimage/primus:${IMAGE_TAG}), not content. Onmain,IMAGE_TAGis alwayslatest, so afterbuild-dockerrepushes under that tag, the check still saw an identical string and reused the stale container instead of pulling the new image. Fixed by pulling first and comparing the resolved image id instead of the tag name.