Skip to content

[WIP] Support .netstandard2.1#3424

Open
gldeng wants to merge 1 commit into
release/1.5.0from
feature/netstand2.1-for-basic-libraries
Open

[WIP] Support .netstandard2.1#3424
gldeng wants to merge 1 commit into
release/1.5.0from
feature/netstand2.1-for-basic-libraries

Conversation

@gldeng

@gldeng gldeng commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@vizipi

vizipi Bot commented Jun 26, 2023

Copy link
Copy Markdown

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
35.71 % 轩辕焮痕 1 15
16.67 % jason-hoopox 7 7
14.29 % ZhangXin 27 6
14.29 % loning 11 6
4.76 % Stephen01Zhang 2 2

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 56.95%[src/AElf.Types/Extensions/IMessageExtensions.cs]
  • 20.54%[src/AElf.Cryptography/IAElfAsymmetricCipherKeyPair.cs]
  • 73.65%[src/AElf.Types/Base58.cs]
  • 88.82%[src/AElf.Types/Extensions/ByteExtensions.cs]
  • 40.27%[src/AElf.Types/IHashProvider.cs]
  • 20.54%[...src/AElf.Cryptography/Exceptions/SignatureOperationExcept]
  • 91.51%[src/AElf.Cryptography/SecretSharing/SecretSharingHelper.cs]
  • 92.69%[src/AElf.Cryptography/CryptoHelper.cs]
  • 80.73%[src/AElf.Types/IBlockBase.cs]
  • 62.47%[src/AElf.Types/Helper/ChainHelper.cs]
  • @vizipi vizipi Bot requested review from hzz780, jason-aelf, loning and zhxymh June 26, 2023 10:17
    @codecov

    codecov Bot commented Jun 26, 2023

    Copy link
    Copy Markdown

    Codecov Report

    ❌ Patch coverage is 89.59811% with 88 lines in your changes missing coverage. Please review.
    ✅ Project coverage is 90.84%. Comparing base (ff547f2) to head (d4d5b6b).
    ⚠️ Report is 204 commits behind head on release/1.5.0.

    Files with missing lines Patch % Lines
    src/AElf.Types/Types/BigIntValue.cs 29.26% 58 Missing ⚠️
    src/AElf.Cryptography/CryptoHelper.cs 79.54% 10 Missing and 8 partials ⚠️
    src/AElf.Types/Types/Address.cs 95.94% 2 Missing and 1 partial ⚠️
    src/AElf.Cryptography/ECDSA/ECParameters.cs 0.00% 2 Missing ⚠️
    src/AElf.Types/Extensions/ByteExtensions.cs 96.29% 1 Missing and 1 partial ⚠️
    src/AElf.Types/Types/Transaction.cs 91.30% 1 Missing and 1 partial ⚠️
    src/AElf.Types/Helper/ByteArrayHelper.cs 97.05% 0 Missing and 1 partial ⚠️
    src/AElf.Types/Helper/SerializationHelper.cs 98.50% 0 Missing and 1 partial ⚠️
    src/AElf.Types/Types/BinaryMerkleTree.cs 98.11% 1 Missing ⚠️
    Additional details and impacted files

    Impacted file tree graph

    @@                Coverage Diff                @@
    ##           release/1.5.0    #3424      +/-   ##
    =================================================
    + Coverage          90.60%   90.84%   +0.23%     
    =================================================
      Files                653      653              
      Lines              24356    24906     +550     
      Branches            2142     2301     +159     
    =================================================
    + Hits               22067    22625     +558     
    + Misses              2184     2176       -8     
      Partials             105      105              
    Files with missing lines Coverage Δ
    src/AElf.Cryptography/ECDSA/ECKeyPair.cs 100.00% <100.00%> (ø)
    ....Cryptography/Exceptions/EcdhOperationException.cs 100.00% <100.00%> (ø)
    ...Cryptography/Exceptions/InvalidKeyPairException.cs 100.00% <100.00%> (ø)
    ...ryptography/Exceptions/InvalidPasswordException.cs 100.00% <100.00%> (ø)
    ...ptography/Exceptions/InvalidPrivateKeyException.cs 100.00% <100.00%> (ø)
    ...yptography/Exceptions/KeyStoreNotFoundException.cs 100.00% <100.00%> (ø)
    ...tography/Exceptions/PublicKeyOperationException.cs 100.00% <100.00%> (ø)
    ...tography/Exceptions/SignatureOperationException.cs 100.00% <100.00%> (ø)
    ....Cryptography/SecretSharing/SecretSharingConsts.cs 100.00% <100.00%> (ø)
    ...ptography/SecretSharing/SecretSharingExtensions.cs 100.00% <100.00%> (ø)
    ... and 24 more

    ... and 4 files with indirect coverage changes

    🚀 New features to boost your workflow:
    • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant