deps: tabled 0.15 to 0.21 - #37
Merged
Merged
Conversation
The findings table is what a user sees after a scan. If a version bump changes a border character or a column width, no compiler notices. One test now holds the exact rendering.
The derive attributes and Table::new are unchanged across the jump, and the golden test added in the previous commit passes unmodified, so the findings table users see is rendered exactly as before. Verified with cargo tree that the build actually moved: tabled v0.21.0. The declaration sits in crates/ghass-cli/Cargo.toml, not in the workspace section, and editing the wrong file would have left the tests reporting green under the old version. clippy with -D warnings and all 92 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erledigt #35.
Die Befundtabelle ist das, was ein Nutzer nach einem Scan sieht. Verschiebt ein Versionssprung ein Rahmenzeichen oder eine Spaltenbreite, merkt das kein Compiler.
Erst das Netz, dann der Sprung
Ein Test, der die exakte Ausgabe festhält, geschrieben und grün gemacht unter 0.15:
Dann
tabledauf 0.21. Derselbe Test, unverändert, läuft durch.Beinahe an der falschen Datei vorbei
Mein erster Versuch, die Version zu heben, griff ins Leere:
tabledsteht hier incrates/ghass-cli/Cargo.tomlund nicht im Workspace-Abschnitt. Der Schreibvorgang scheiterte, die Tests liefen danach trotzdem grün, nur eben weiterhin unter 0.15.Genau deshalb prüfe ich das inzwischen mit
cargo treestatt mit dem Diff:Ein grüner Test unter der alten Version sieht identisch aus wie einer unter der neuen.
clippy -D warningssauber, alle 92 Tests grün.