support multiple assignment of export.default in Babel 7#82
Open
henryqdineen wants to merge 1 commit into59naga:masterfrom
Open
support multiple assignment of export.default in Babel 7#82henryqdineen wants to merge 1 commit into59naga:masterfrom
henryqdineen wants to merge 1 commit into59naga:masterfrom
Conversation
|
@59naga Could you take a look at this? |
This was referenced Sep 7, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran into an odd issue when migrating from Babel 6 to 7 that I tracked down to this plugin. It is specific to Babel 7 and using the same variable multiple times in a ExportNamedDeclaration. I understand that this is plugin is deprecated and don't expect new version but I thought I would leave this here for posterity.
Consider this code here:
In Babel 6 it would be transpiled as:
In Babel 7 it would be transpiled as:
The issue I found is that
babel-plugin-add-module-exportswill incorrectly add themodule.exportsbecause theisOnlyExportsDefault()does not correctly handle the case ofexports.default = exports.foo = foo;. It only looks at root level expression statements and does not expect this multiple assignment.My quick fix was to recursively call
findExportson the right hand side of the assignment so it can analyze the other exports.