Skip to content

Fix list serializer #19

Merged
Joel-Luca merged 3 commits into
masterfrom
jch/TI-3779
Apr 16, 2026
Merged

Fix list serializer #19
Joel-Luca merged 3 commits into
masterfrom
jch/TI-3779

Conversation

@Joel-Luca

@Joel-Luca Joel-Luca commented Apr 16, 2026

Copy link
Copy Markdown
Member

Description

  • Change property serializer and data mapping serializer to mixins
  • Add type ignores for properties and write test with validation error

Belongs to PBI TI-3779.

Checklist

The following checklist should help us to stick to our "definition of done":

  • Proposed changes include tests.
  • Good error handling with useful messages
  • Changelog added
  • Django migration files have a meaningful name (not 0000_auto_xyz.py nor 0000_alter_xy_model).
  • Strings are set and translation catalogs have been updated (i18n-scan or i18n-update) and translations made.
  • Readme has been updated if changes interfere with the setup process.

The list data mapping serializer calls the parent methods from the
serializers.Serializer iff the data mapping serializer inherits from
serializers.Serializer.
@Joel-Luca Joel-Luca requested a review from a team April 16, 2026 04:04
Comment thread django_features/serializers.py
@Joel-Luca Joel-Luca requested a review from xenoy April 16, 2026 07:42

@xenoy xenoy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joel-Luca Joel-Luca merged commit 199fc6b into master Apr 16, 2026
1 check passed
@Joel-Luca Joel-Luca deleted the jch/TI-3779 branch April 16, 2026 07:55
Joel-Luca added a commit that referenced this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants